Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/milestone2 #112

Merged
merged 29 commits into from
Mar 29, 2024
Merged

Feature/milestone2 #112

merged 29 commits into from
Mar 29, 2024

Conversation

windoverwater
Copy link
Collaborator

@windoverwater windoverwater commented Mar 27, 2024

This started as a matching branch for the VTP-web-client milestone2 work to support html output. However, several aspects of the low level data model as well as the OO class design were just too busted to not take the plunge and address some of the issues. So, this is has become rather large.

  • moved the referenced methods of the Shellout class into Operations and deleted the rest
  • in the Ballot class, the contests were a dictionary of arrays (of contest dicts) and are now an array of Contest objects
  • obliterated the Contests custom iterator class (yeah - though it was fun to write)
  • removed the use of the logger class and replaced with the Operator.imprimir class/method
  • addressed the inconsistency of verbose printing (as it 'was' implemented across the logger and Operator classes)
  • placed all the 'default missing values' via the config.yaml files into the parsing phase - after config file parsing, there are no longer any missing values - all values are now specified in the objects (and above)
  • cleaned up the Contest object key names - no more overlaps
  • addressed the lurking 'max_selections' RCV bug by explicitly deciding that current definition of RCV actually means IRV with a single winner - max_selections now only refers to the maximum number of choices a voter can make and does not also refer to how many RCV candidates can win

This resulted bumping the setup_tools version from 0.1.0 to 0.2.0 since the contestCVR structure (in the git log's) is now different

The above is in addition to supporting basic html coloring so that the javascript code does not have to regex it's way through text that can too easily change, etc.

…es wild :-); this alters the format of the ElectionData config.yaml file syntax
…2) fixed shell_out verbosity handling; removed the class Common (no longer used); 3) create a single verbosity default
@windoverwater windoverwater self-assigned this Mar 27, 2024
@windoverwater windoverwater merged commit e7f7fd5 into main Mar 29, 2024
2 checks passed
@windoverwater windoverwater deleted the feature/milestone2 branch March 29, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant