Skip to content

Fix incorrect instances of its and it's #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tone/component/dynamics/Limiter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export interface LimiterOptions extends ToneAudioNodeOptions {

/**
* Limiter will limit the loudness of an incoming signal.
* Under the hood it's composed of a {@link Compressor} with a fast attack
* Under the hood its composed of a {@link Compressor} with a fast attack
* and release and max compression ratio.
*
* @example
Expand Down
2 changes: 1 addition & 1 deletion Tone/component/envelope/AmplitudeEnvelope.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class AmplitudeEnvelope extends Envelope {
input: Gain = this._gainNode;

/**
* @param attack The amount of time it takes for the envelope to go from 0 to it's maximum value.
* @param attack The amount of time it takes for the envelope to go from 0 to its maximum value.
* @param decay The period of time after the attack that it takes for the envelope
* to fall to the sustain value. Value must be greater than 0.
* @param sustain The percent of the maximum value that the envelope rests at until
Expand Down
6 changes: 3 additions & 3 deletions Tone/component/envelope/Envelope.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class Envelope extends ToneAudioNode<EnvelopeOptions> {

/**
* When triggerAttack is called, the attack time is the amount of
* time it takes for the envelope to reach it's maximum value.
* time it takes for the envelope to reach its maximum value.
* ```
* /\
* /X \
Expand All @@ -77,7 +77,7 @@ export class Envelope extends ToneAudioNode<EnvelopeOptions> {

/**
* After the attack portion of the envelope, the value will fall
* over the duration of the decay time to it's sustain value.
* over the duration of the decay time to its sustain value.
* ```
* /\
* / X\
Expand Down Expand Up @@ -170,7 +170,7 @@ export class Envelope extends ToneAudioNode<EnvelopeOptions> {

/**
* @param attack The amount of time it takes for the envelope to go from
* 0 to it's maximum value.
* 0 to its maximum value.
* @param decay The period of time after the attack that it takes for the envelope
* to fall to the sustain value. Value must be greater than 0.
* @param sustain The percent of the maximum value that the envelope rests at until
Expand Down
2 changes: 1 addition & 1 deletion Tone/core/clock/Clock.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ describe("Clock", () => {
expect(clock.frequency.value).to.equal(8);
});

it("can get and set it's values with the set/get", () => {
it("can get and set its values with the set/get", () => {
const clock = new Clock();
clock.set({
frequency: 2,
Expand Down
10 changes: 5 additions & 5 deletions Tone/core/context/AbstractParam.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export abstract class AbstractParam<TypeName extends UnitName> {
* duration of the rampTime.
* @param value The value to ramp to.
* @param rampTime the time that it takes the
* value to ramp from it's current value
* value to ramp from its current value
* @param startTime When the ramp should start.
* @example
* const delay = new Tone.FeedbackDelay(0.5, 0.98).toDestination();
Expand All @@ -114,7 +114,7 @@ export abstract class AbstractParam<TypeName extends UnitName> {
*
* @param value The value to ramp to.
* @param rampTime the time that it takes the
* value to ramp from it's current value
* value to ramp from its current value
* @param startTime When the ramp should start.
* @returns {Param} this
* @example
Expand All @@ -141,7 +141,7 @@ export abstract class AbstractParam<TypeName extends UnitName> {
* rampTime is the time that it takes to reach over 99% of the way towards the value.
* @param value The value to ramp to.
* @param rampTime the time that it takes the
* value to ramp from it's current value
* value to ramp from its current value
* @param startTime When the ramp should start.
* @example
* @example
Expand All @@ -163,7 +163,7 @@ export abstract class AbstractParam<TypeName extends UnitName> {
* is similar to setTargetAtTime except the third argument is a time instead of a 'timeConstant'
* @param value The value to ramp to.
* @param time When the ramp should start.
* @param rampTime the time that it takes the value to ramp from it's current value
* @param rampTime the time that it takes the value to ramp from its current value
* @example
* const osc = new Tone.Oscillator().toDestination().start();
* // exponential approach over 4 seconds starting in 1 second
Expand Down Expand Up @@ -243,7 +243,7 @@ export abstract class AbstractParam<TypeName extends UnitName> {
* depending on the `units` of the signal
*
* @param value
* @param rampTime The time that it takes the value to ramp from it's current value
* @param rampTime The time that it takes the value to ramp from its current value
* @param startTime When the ramp should start.
* @example
* const osc = new Tone.Oscillator().toDestination().start();
Expand Down
2 changes: 1 addition & 1 deletion Tone/core/context/ToneAudioBuffer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export class ToneAudioBuffer extends Tone {
if (buffer.loaded) {
this._buffer = buffer.get();
} else {
// otherwise when it's loaded, invoke it's callback
// otherwise when its loaded, invoke it's callback
buffer.onload = () => {
this.set(buffer);
this.onload(this);
Expand Down
2 changes: 1 addition & 1 deletion Tone/core/util/IntervalTimeline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ class IntervalNode {
}

/**
* Invoke the callback on this element and both it's branches
* Invoke the callback on this element and both its branches
* @param {Function} callback
*/
traverse(callback: (self: IntervalNode) => void): void {
Expand Down
2 changes: 1 addition & 1 deletion Tone/core/worklet/ToneAudioWorkletProcessor.worklet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const toneAudioWorkletProcessor = /* javascript */ `

super(options);
/**
* If the processor was disposed or not. Keep alive until it's disposed.
* If the processor was disposed or not. Keep alive until its disposed.
*/
this.disposed = false;
/**
Expand Down
2 changes: 1 addition & 1 deletion Tone/effect/AutoFilter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export interface AutoFilterOptions extends LFOEffectOptions {
* and depth.
*
* @example
* // create an autofilter and start it's LFO
* // create an autofilter and start its LFO
* const autoFilter = new Tone.AutoFilter("4n").toDestination().start();
* // route an oscillator through the filter and start it
* const oscillator = new Tone.Oscillator().connect(autoFilter).start();
Expand Down
2 changes: 1 addition & 1 deletion Tone/effect/Tremolo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export interface TremoloOptions extends StereoEffectOptions {
* The effect is a stereo effect where the modulation phase is inverted in each channel.
*
* @example
* // create a tremolo and start it's LFO
* // create a tremolo and start its LFO
* const tremolo = new Tone.Tremolo(9, 0.75).toDestination().start();
* // route an oscillator through the tremolo and start it
* const oscillator = new Tone.Oscillator().connect(tremolo).start();
Expand Down
4 changes: 2 additions & 2 deletions Tone/instrument/Sampler.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ describe("Sampler", () => {
});

context("add samples", () => {
it("can add a note with it's midi value", async () => {
it("can add a note with its midi value", async () => {
const buffer = await Offline(() => {
const sampler = new Sampler().toDestination();
sampler.add(69, A4_buffer);
Expand All @@ -276,7 +276,7 @@ describe("Sampler", () => {
expect(buffer.isSilent()).to.be.false;
});

it("can add a note with it's note name", async () => {
it("can add a note with its note name", async () => {
const buffer = await Offline(() => {
const sampler = new Sampler().toDestination();
sampler.add("A4", A4_buffer);
Expand Down
2 changes: 1 addition & 1 deletion Tone/signal/Zero.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { SignalOperator } from "./SignalOperator.js";

/**
* Tone.Zero outputs 0's at audio-rate. The reason this has to be
* it's own class is that many browsers optimize out Tone.Signal
* its own class is that many browsers optimize out Tone.Signal
* with a value of 0 and will not process nodes further down the graph.
* @category Signal
*/
Expand Down
2 changes: 1 addition & 1 deletion Tone/source/Source.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export abstract class Source<
offset?: Seconds;
/**
* Either the buffer is explicitly scheduled to end using the stop method,
* or it's implicitly ended when the buffer is over.
* or its implicitly ended when the buffer is over.
*/
implicitEnd?: boolean;
}> = new StateTimeline("stopped");
Expand Down
4 changes: 2 additions & 2 deletions Tone/source/buffer/Player.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class Player extends Source<PlayerOptions> {
private _buffer: ToneAudioBuffer;

/**
* if the buffer should loop once it's over
* if the buffer should loop once its over
*/
private _loop: boolean;

Expand Down Expand Up @@ -369,7 +369,7 @@ export class Player extends Source<PlayerOptions> {
}

/**
* If the buffer should loop once it's over.
* If the buffer should loop once its over.
* @example
* const player = new Tone.Player("https://tonejs.github.io/audio/drum-samples/breakbeat.mp3").toDestination();
* player.loop = true;
Expand Down
2 changes: 1 addition & 1 deletion Tone/source/buffer/ToneBufferSource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ export class ToneBufferSource extends OneShotSource<ToneBufferSourceOptions> {
}

/**
* If the buffer should loop once it's over.
* If the buffer should loop once its over.
*/
get loop(): boolean {
return this._source.loop;
Expand Down
2 changes: 1 addition & 1 deletion Tone/source/oscillator/LFO.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ describe("LFO", () => {
expect(buffer.max()).to.be.lte(18);
});

it("initially outputs a signal at the center of it's phase", async () => {
it("initially outputs a signal at the center of its phase", async () => {
const buffer = await Offline(() => {
new LFO(100, 10, 20).toDestination();
});
Expand Down
2 changes: 1 addition & 1 deletion Tone/source/oscillator/LFO.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class LFO extends ToneAudioNode<LFOOptions> {
private _zeros: Zero;

/**
* The value that the LFO outputs when it's stopped
* The value that the LFO outputs when its stopped
*/
private _stoppedValue = 0;

Expand Down
2 changes: 1 addition & 1 deletion Tone/source/oscillator/PWMOscillator.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe("PWMOscillator", () => {
});

context("Types", () => {
it("reports it's type", () => {
it("reports its type", () => {
const osc = new PWMOscillator();
expect(osc.type).to.equal("pwm");
expect(osc.baseType).to.equal("pwm");
Expand Down
2 changes: 1 addition & 1 deletion Tone/source/oscillator/PulseOscillator.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ describe("PulseOscillator", () => {
});

context("Types", () => {
it("reports it's type", () => {
it("reports its type", () => {
const osc = new PulseOscillator();
expect(osc.type).to.equal("pulse");
expect(osc.baseType).to.equal("pulse");
Expand Down
4 changes: 2 additions & 2 deletions test/helper/Basic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function BasicTests(Constr, ...args: any[]): void {
instance.dispose();
// check that all of the attributes were disposed
expect(instance.disposed).to.equal(true);
// also check all of it's attributes to see if they also have the right context
// also check all of its attributes to see if they also have the right context
for (const member in instance) {
if (instance[member] instanceof Tone && member !== "context") {
expect(
Expand Down Expand Up @@ -59,7 +59,7 @@ export function BasicTests(Constr, ...args: any[]): void {
);
if (instance instanceof ToneWithContext) {
expect(instance.context).to.equal(testAudioContext);
// also check all of it's attributes to see if they also have the right context
// also check all of its attributes to see if they also have the right context
for (const member in instance) {
if (instance[member] instanceof ToneWithContext) {
expect(
Expand Down