Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable RedundantModifier in checkstyle #5140

Merged
merged 1 commit into from
May 3, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented May 3, 2024

Related to #5119

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@vil02 vil02 marked this pull request as ready for review May 3, 2024 18:10
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 38.88889% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 37.34%. Comparing base (1e2d7e9) to head (f33617f).

Files Patch % Lines
...ithms/datastructures/trees/PrintTopViewofTree.java 0.00% 4 Missing ⚠️
...om/thealgorithms/datastructures/graphs/A_Star.java 0.00% 3 Missing ⚠️
...thms/datastructures/graphs/ConnectedComponent.java 0.00% 3 Missing ⚠️
...c/main/java/com/thealgorithms/others/Dijkstra.java 0.00% 3 Missing ⚠️
...om/thealgorithms/datastructures/graphs/Graphs.java 0.00% 2 Missing ⚠️
...ithms/datastructures/stacks/StackOfLinkedList.java 0.00% 2 Missing ⚠️
...gorithms/datastructures/trees/nearestRightKey.java 0.00% 2 Missing ⚠️
...ava/com/thealgorithms/datastructures/bags/Bag.java 0.00% 1 Missing ⚠️
.../thealgorithms/datastructures/caches/LRUCache.java 50.00% 1 Missing ⚠️
.../thealgorithms/datastructures/caches/MRUCache.java 50.00% 1 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5140   +/-   ##
=========================================
  Coverage     37.33%   37.34%           
- Complexity     2348     2349    +1     
=========================================
  Files           517      517           
  Lines         15618    15618           
  Branches       2971     2971           
=========================================
+ Hits           5831     5832    +1     
  Misses         9497     9497           
+ Partials        290      289    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit b3903f5 into TheAlgorithms:master May 3, 2024
5 checks passed
@vil02 vil02 deleted the enable_RedundantModifier branch May 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants