[OTHER] Enable more checks in checkstyle

[vil02]

What would you like to share?

#5110 introduced checkstyle. The config file has some of the rules commented out. It might a good idea to introduce some of them and discuss why the other ones are not needed in this repository.

List of checks which should be introduced

Few of the obvious checks, which should be introduced:

• ConstantName (style: enable ConstantName in checkstyle #5139 by @marysiuniq)
• LocalFinalVariableName
• LocalVariableName
• MemberName
• MethodName
• ParameterName
• StaticVariableName
• TypeName
• AvoidStarImport (style: enable AvoidStarImport in checkstyle #5141)
• ModifierOrder (style: enable ModifierOrder in checkstyle #5132 by @marysiuniq)
• RedundantModifier (style: enable RedundantModifier in checkstyle #5140)
• EmptyStatement (style: enable EmptyStatement #5120)
• MultipleVariableDeclarations
• HideUtilityClassConstructor (style: enable HideUtilityClassConstructor in checkstyle #5147)
• ArrayTypeStyle (style: enable ArrayTypeStyle in checkstyle #5145)
• InvalidJavadocPosition
• OperatorWrap
• ParenPad
• EqualsHashCode (style: enable EqualsHashCode in checkstyle #5157 by @CodaBlurd)
• InnerAssignment (style: enabled InnerAssignment in checkstyle #5162 by @CodaBlurd)
• FinalClass (style: enable FinalClass in checkstyle #5154 by @CodaBlurd)

(@siriak, @BamaCharanChhandogi feel free to edit the list above)

Additional information

How to contribute

1. select one check form the list above such that no one else is working on (and is not done yet),
2. write a comment "Hey, I am working on XYZ", where XYZ is your selected check,
3. in your fork, please create a branch like enable_XYZ,
4. uncomment the XYZ check in the checkstyle.xml,
5. run mvn checkstyle:check and fix all of the errors - please keep your changes minimal,
6. commit your changes with a message like "style: enable XYZ in checkstyle",
7. create a pull-request and mention this issue by writing something like "Related to [OTHER] Enable more checks in checkstyle #5119".

[vil02]

I will work on EmptyStatement.

[marysiuniq]

Hey, I will be working on ModifierOrder.

[marysiuniq]

Now, I will be working on ConstantName.

[vil02]

I will work on RedundantModifier.

[vil02]

I will slowly work on AvoidStarImport.

[VedSansare89]

Hey, I will be working on MethodName

[vil02]

I will work on ArrayTypeStyle.

[vil02]

I will work on HideUtilityClassConstructor.

[vil02]

@siriak, @BamaCharanChhandogi I have extended the list of obvious checks. Please have a look and edit the list if needed.

[CodaBlurd]

Hi, I will be working on FinalClass.

[CodaBlurd]

I will work on EqualsHashCode.

[CodaBlurd]

I will work on InnerAssignment.