Skip to content

fix: remove memory leak iterative_factorial.cpp #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realstealthninja merged 2 commits into from
Aug 30, 2024
Merged

fix: remove memory leak iterative_factorial.cpp #2535

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e015c59
fix: remove memory leak
vil02 Sep 18, 2023
443d2ff
tests: check properly if `math::iterativeFactorial` throws
vil02 Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions math/iterative_factorial.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ namespace math {
*/
uint64_t iterativeFactorial(uint8_t n) {
if (n > 20) {
throw new std::invalid_argument("Maximum n value is 20");
throw std::invalid_argument("Maximum n value is 20");
}

// 1 because it is the identity number of multiplication.
Expand Down Expand Up @@ -101,12 +101,14 @@ static void test() {
std::cout << "Exception test \n"
"Input: 21 \n"
"Expected output: Exception thrown \n";

bool wasExceptionThrown = false;
try {
math::iterativeFactorial(21);
} catch (std::invalid_argument* e) {
std::cout << "Exception thrown successfully \nContent: " << e->what()
<< "\n";
} catch (const std::invalid_argument&) {
wasExceptionThrown = true;
}
assert(wasExceptionThrown);

std::cout << "All tests have passed successfully.\n";
}
Expand Down