fix: remove memory leak iterative_factorial.cpp
#2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vil02
requested review from
Panquesito7 and
realstealthninja
as code owners
CarlosZoft
reviewed
Sep 22, 2023
|
@vil02, some suggestions.. pls resolve the conflits
|
vil02
force-pushed
the
memory_leak_iterative_factorial_patch
branch
from
4fe4cf4
to
e4ada59
Compare
@CarlosZoft luckily there were no conflicts, just my branch was out-of-date. It is fixed now. |
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
@Panquesito7, @realstealthninja: Merry Christmas and please |
github-actions
bot
removed
the
stale
vil02
force-pushed
the
memory_leak_iterative_factorial_patch
branch
from
e4ada59
to
a86a017
Compare
vil02
force-pushed
the
memory_leak_iterative_factorial_patch
branch
from
a86a017
to
443d2ff
Compare
|
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
|
Please add |
CarlosZoft
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
There is a memory leak in
iterative_factorial.cppwhile throwing an exception. This PR fixes it and does some other small changes.Checklist
Added file name matches File name guidelinesAdded tests and example, test must passAdded documentation so that the program is self-explanatory and educational - Doxygen guidelinesRelevant documentation/comments is changed or addedNotes:
Removes memory leak in
iterative_factorial.cpp.