Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths in release.rake homebrew part #trivial #1115

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Liquidsoul
Copy link
Member

  • I've started my branch from the develop branch (gitflow)
    • And I've selected develop as the "base" branch for this Pull Request I'm about to create
  • I've added #trivial to the PR title if I think it doesn't warrant a mention in the CHANGELOG)

I've stumbled on this when I released the 6.6.3.

@Liquidsoul Liquidsoul changed the base branch from stable to develop March 15, 2024 15:18
@SwiftGen-Eve
Copy link

SwiftGen-Eve commented Mar 15, 2024

Hey 👋 I'm Eve, the friendly bot watching over SwiftGen 🤖

Thanks a lot for your contribution!


Seems like everything is in order 👍 You did a good job here! 🤝

Generated by 🚫 Danger

@Liquidsoul Liquidsoul force-pushed the fix/release/script branch 2 times, most recently from 0e48049 to d1394bd Compare March 15, 2024 16:10
Copy link
Member

@djbe djbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, GitHub must've changed their URL structure.

- archive URL must include the 'refs/tags' part
- the formula is now inside a `s` folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants