Skip to content

Implement up and down direction for swimming fish #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

Hypernoot
Copy link
Member

@Hypernoot Hypernoot commented Apr 5, 2025

fixes #2573

I hate the implementation but some compromise has to be done in order to fit it into 0.7.0. To make the code nicer, I need all the following:

  • A transpose-action sprite modifier, to make the fish visually facing up or down.
  • Make the chasing fish use 4 different rotations instead of just 2.
  • A better interoperability between vectors and directions. There should be at least functions to obtain a unit vector from direction and a direction from vector.

As this seems as a bigger task, the question is, whether it makes sense to put it into 0.7.0 or not. There are three options:

  1. Merge this PR as it is and then report these tasks as a bug to be solved in 0.7.1.
  2. Postpone whole this stuff to 0.7.1
  3. Add these tasks to the scope to 0.7.0 and then provide a proper solution.

@Rusty-Box
Copy link
Member

Rusty-Box commented Apr 5, 2025

I don’t think Swimming Fish moving up and down needs to literally look up and down. I‘d even argue that‘d look worse. They simply just need to move up and down on the spot (range can be set in editor). A bit like Dive Mine but obviously a bit further

@Hypernoot
Copy link
Member Author

Okay. In that case, the first two points are not needed. The first one may be still handy for other purposes.

There's just one issue with the chasing fish. When the fish stops chasing Tux, shall it continue moving horizontally, vertically, or how? I currently implemented that so it moves horizontally no matter what. But maybe it should move based on how it was moving originally. Or maybe according to the direction in which Tux escaped?

Copy link
Member

@Frostwithasideofsalt Frostwithasideofsalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually looks a bit odd, but it works

@tobbi
Copy link
Member

tobbi commented Apr 16, 2025

Can I have a video on how it looks? Don't feel like compiling / downloading a nightly build.

@Vankata453 Vankata453 added this to the 0.7.0 milestone May 26, 2025
@Hypernoot
Copy link
Member Author

@Vankata453 Vankata453 merged commit f2546ec into SuperTux:master May 28, 2025
7 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow fish badguys to move up/down
5 participants