pack update #25
Merged
pack update #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nzlosh
commented
Jun 7, 2022
nzlosh
commented
- Add action to generate secrets.
- Add profile support to pack to define multiple Vault end-points.
- Updated README with full list of available actions.
- Fixes TLS support for server and client certificates.
nzlosh
force-pushed
the
tls_fixes
branch
5 times, most recently
from
bf40482 to
6d3912c
Compare
nzlosh
force-pushed
the
tls_fixes
branch
24 times, most recently
from
9d71c05 to
43b019e
Compare
arm4b
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Lots of changes and tidy-up 👍
I'm not a fan of README generation, as it might be error-prone when others updating the README.md manually and files might conflict/override each-other, but it's nice to see someone with a strong ownership maintaining the pack.
On that note, requested a few minor changes.
arm4b
reviewed
Aug 23, 2023
arm4b
reviewed
Aug 23, 2023
Merged
arm4b
suggested changes
Sep 5, 2023
|
|
arm4b
reviewed
Sep 7, 2023
|
Thanks for the review @armab much appreciated ❤️ |
|
@nzlosh great work on v2.0 of the pack! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.