add maintainers list #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cognifloyd
force-pushed
the
cognifloyd-maintainer
branch
2 times, most recently
from
608be7e to
d62d223
Compare
cognifloyd
force-pushed
the
cognifloyd-maintainer
branch
from
d62d223 to
aca54fa
Compare
arm4b
suggested changes
Jun 16, 2021
|
|
||
| # This is base configuration. These owners could review the | ||
| # changes in all files in this repository. | ||
| * @cognifloyd |
There was a problem hiding this comment.
Suggested change
| * @cognifloyd | |
| * @StackStorm-Exchange/tsc @cognifloyd |
I guess there are more codeowners here. I don't think you expect to review your own PRs 😃 and TSC group will be also automatically requested for new PR reviews.
TSC are maintainers for the entire Exchange and it's shared group responsibility to keep it working. We're load-balancing the work here sometimes.
Hope that clarifies the question.
There was a problem hiding this comment.
I cannot be responsible for adding the TSC to something where they will be pinged for every change. Without fail, whenever I start debugging something on the exchange or start working on a mass update, someone on the TSC complains about the notifications.
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CODEOWNERS as described in StackStorm-Exchange/exchange-incubator#152
Who else should be included in the maintainers list?
I did not include TSC in
*because I think that is far too aggressive. Only a few of the TSC membersactively maintain packs across the exchange. We shouldn't spam everyone else.
A new group might be nice to specify "people who maintain all packs on the exchange".