Improve chat api toLegacy conversion #3625
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the suggested change in #3623 and improves test case code and changes the test cases affected by this change of removing unneccessary color codes in legacy output.
Additionally it improves all the componenets toString methods by not showing null methods, integrating style toString and using shorter names.moved to separate PRThis PR has a slight unwanted side effect when converting uncolored translatable components with styled parameters to legacy - in these cases the style of the parameter will stay after the styled parameter ends.Should we fix that with special casing in transable component somehow and what would be the best way of doing so?This PR overhauls toLegacy conversion with context-aware algorithm which only adds formatting codes if needed in most cases.