Create shorter toString of components #3663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janmm14
force-pushed
the
better-chat-component-tostring
branch
from
4009e28
to
e58bb50
Compare
- stop mentioning null values - use shorter names - seamless integration of style's toString Also use just one string builder and keep track of whether a comma is needed before the next property.
Janmm14
force-pushed
the
better-chat-component-tostring
branch
from
e58bb50
to
0a97ab6
Compare
|
Why? |
|
Debugging purposes, and it doesn't hurt. I created it because previous impl (lombok) annoyed me during debugging legacy conversion improvement with all the xxx=null outputs. |
|
I'm not particularly keen on this. Lombok is there to eliminate this boilerplate |
|
Well then maybe not. Its not that important to be merged. Sadly lombok has no way of excluding fields with null values. |
|
I've found a lombok ferature request to not print null values, but its just idling since 2021 projectlombok/lombok#3038 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done by:
Also use just one string builder and keep track of whether a comma is needed before the next property.
Extracted from #3625