Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExprTypeOf - add support for EnchantmentType #7340

Open
wants to merge 1 commit into
base: dev/feature
Choose a base branch
from
Open

ExprTypeOf - add support for EnchantmentType #7340

wants to merge 1 commit into from

Conversation

ShaneBeee
Copy link
Contributor

Description

This PR aims to add support for EnchantmentType in ExprTypeOf since Skript does not have anything to get the enchantment from an EnchantmentType

Target Minecraft Versions: any
Requirements: none
Related Issues: none

@sovdeeth
Copy link
Member

sovdeeth commented Jan 1, 2025

this should probably be an any-x syntax tbh

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jan 1, 2025
@ShaneBeee
Copy link
Contributor Author

ShaneBeee commented Jan 1, 2025 •
edited
Loading

this should probably be an any-x syntax tbh

Ok, so I gave it a whirl, and I had no luck, so I should leave that to someone else to do.
Hold the phone, might have figured it out
hanging up the phone ... I tried, I failed, I gave up!

@sovdeeth sovdeeth mentioned this pull request Jan 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaneBeee @sovdeeth