AnyTyped #7343
Closed
AnyTyped #7343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
enhancement
Moderocky
reviewed
Jan 1, 2025
Comment on lines
54
to
60
| return EntityData.class.isAssignableFrom(returnType) ? EntityData.class | ||
| : ItemType.class.isAssignableFrom(returnType) ? ItemType.class | ||
| : PotionEffectType.class.isAssignableFrom(returnType) ? PotionEffectType.class | ||
| : BlockData.class.isAssignableFrom(returnType) ? ItemType.class : Object.class; | ||
| : BlockData.class.isAssignableFrom(returnType) ? ItemType.class | ||
| : EnchantmentType.class.isAssignableFrom(returnType) ? Enchantment.class | ||
| : Object.class; | ||
| } |
There was a problem hiding this comment.
Is this still safe? Won't the expression type just be the converted AnyTyped for BlockData and potions?
There was a problem hiding this comment.
yeah this draft basically needs to be redone, I think I'll be closing it for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AnyProvider for typed classes, to support extensions of ExprTypeOf.
Supersedes #7340 if it works.
Target Minecraft Versions: any
Requirements: none
Related Issues: none