Allow the user to save the tracking information server side instead of in a cookie #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loevgaard
force-pushed
the
client-metadata-storage
branch
5 times, most recently
from
2b2afa5 to
f8f2db5
Compare
loevgaard
force-pushed
the
client-metadata-storage
branch
from
f8f2db5 to
689c83e
Compare
leflings
reviewed
May 14, 2024
| } | ||
|
|
||
| try { | ||
| $cookie = $this->trackingInformation->toCookie($this->cookieName, 1); |
There was a problem hiding this comment.
Jeg antager at vi vil fjerne cookien, men det er måske ikke direkte muligt? Og at vi i stedet sætter den til at expire om 1 sekund?
There was a problem hiding this comment.
Ja, det er sådan, Symfony gør det: https://github.com/symfony/symfony/blob/7.0/src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php#L222. Grunden til, at jeg ikke bruger deres metode til det er at der (vist nok) er nogle gange en cookie ikke bliver slettet, hvis man ikke angiver de samme parametre for cookien, som den blev sat med.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.