Vuu 81 definition as json node #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vferraro-scottlogic
requested review from
heswell,
pling-scottlogic and
cfisher-scottlogic
pling-scottlogic
requested changes
Nov 13, 2023
layout-server/src/main/java/org/finos/vuu/layoutserver/dto/request/LayoutRequestDto.java
Outdated
Show resolved
Hide resolved
layout-server/src/main/java/org/finos/vuu/layoutserver/utils/ObjectNodeConverter.java
Outdated
Show resolved
Hide resolved
layout-server/src/test/java/org/finos/vuu/layoutserver/integration/LayoutIntegrationTest.java
Outdated
Show resolved
Hide resolved
layout-server/src/test/java/org/finos/vuu/layoutserver/integration/LayoutIntegrationTest.java
Outdated
Show resolved
Hide resolved
...ut-server/src/test/java/org/finos/vuu/layoutserver/service/ApplicationLayoutServiceTest.java
Outdated
Show resolved
Hide resolved
...ut-server/src/test/java/org/finos/vuu/layoutserver/service/ApplicationLayoutServiceTest.java
Outdated
Show resolved
Hide resolved
layout-server/src/test/java/org/finos/vuu/layoutserver/integration/LayoutIntegrationTest.java
Outdated
Show resolved
Hide resolved
pling-scottlogic
force-pushed
the
main
branch
from
eea27db
to
6a24965
Compare
vferraro-scottlogic
force-pushed
the
VUU-81-definition-as-JsonNode
branch
from
427f2db
to
8065a56
Compare
cfisher-scottlogic
approved these changes
Nov 15, 2023
vferraro-scottlogic
changed the base branch from
main
to
VUU333-layout-server
vferraro-scottlogic
force-pushed
the
VUU-81-definition-as-JsonNode
branch
from
8065a56
to
5911f5f
Compare
pling-scottlogic
requested changes
Nov 15, 2023
layout-server/src/main/java/org/finos/vuu/layoutserver/utils/ObjectNodeConverter.java
Show resolved
Hide resolved
layout-server/src/main/java/org/finos/vuu/layoutserver/utils/ObjectNodeConverter.java
Outdated
Show resolved
Hide resolved
layout-server/src/test/java/org/finos/vuu/layoutserver/integration/LayoutIntegrationTest.java
Outdated
Show resolved
Hide resolved
layout-server/src/main/java/org/finos/vuu/layoutserver/dto/request/LayoutRequestDto.java
Outdated
Show resolved
Hide resolved
layout-server/src/main/java/org/finos/vuu/layoutserver/dto/response/LayoutResponseDto.java
Outdated
Show resolved
Hide resolved
layout-server/src/main/java/org/finos/vuu/layoutserver/dto/request/LayoutRequestDto.java
Show resolved
Hide resolved
|
|
||
| service.persistApplicationLayout(user, definition); | ||
|
|
||
| verify(mockRepo, times(1)) | ||
| .save(new ApplicationLayout(user, definition)); | ||
| } | ||
|
|
||
| @Test | ||
| public void createApplicationLayout_invalidDefinition_throwsJsonException() { |
There was a problem hiding this comment.
this test case is not relevant anymore as definition is now an ObjectNode rather than a string
pling-scottlogic
approved these changes
Nov 16, 2023
| @@ -32,14 +39,16 @@ | |||
| @ActiveProfiles("test") | |||
| public class LayoutIntegrationTest { | |||
|
|
|||
| private static final String DEFAULT_LAYOUT_DEFINITION = "Default layout definition"; | |||
| private static final String DEFAULT_LAYOUT_DEFINITION_STRING = "{\"id\":\"main-tabs\"}"; | |||
| private static final String DEFAULT_UPDATED_LAYOUT_DEFINITION_STRING = "{\"id\":\"updated-main-tabs\"}"; | |||
There was a problem hiding this comment.
Minor semantic thing that's not going to stop me from approving: I would remove the word "default" and just call this UPDATED_LAYOUT_DEFINITION_STRING.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes