Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JsonNode in Layout DTOs #81

Open
cfisher-scottlogic opened this issue Oct 19, 2023 · 1 comment · Fixed by #104
Open

Implement JsonNode in Layout DTOs #81

cfisher-scottlogic opened this issue Oct 19, 2023 · 1 comment · Fixed by #104
Assignees
Labels
enhancement New feature or request

Comments

@cfisher-scottlogic
Copy link

cfisher-scottlogic commented Oct 19, 2023

Background

Layout definitions are currently being transferred to and from the server as raw string values in a single JSON field. Since the layout is defined in a JSON format, we want to embed this as a fully formed node within the request/response.

Work Required

  • Convert the definition fields in all layout DTOs and entities from String to JsonNode (import from Jackson databind)
  • Annotate the entity field with @Convert to make use of the existing JsonNodeConverter

Notes

@cfisher-scottlogic
Copy link
Author

cfisher-scottlogic commented Oct 20, 2023

Started working on this whilst I was waiting for #25 to be reviewed. Now that's been merged I'll be focusing on #66, so this can be picked up by someone else.

Branch (WIP): https://github.com/ScottLogic/finos-vuu/tree/VUU81-jsonnode-in-layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants