Fix missing comment on pull request #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-rudyk
force-pushed
the
m.rudyk/fix_absent_comment
branch
from
57ff5ec to
5740a31
Compare
|
Issue occured due to parser transform |
tiokim
reviewed
Sep 12, 2023
Comment on lines
+255
to
+259
| if (null != webhookConfig.getHubLink()) { | ||
| commitCommentBuilder.append("("); | ||
| commitCommentBuilder.append(webhookConfig.getHubLink()); | ||
| commitCommentBuilder.append(")"); | ||
| } |
There was a problem hiding this comment.
What about removing hubLink in LPVSQueue? I don't think that LPVS set and use the value.
There was a problem hiding this comment.
We prefer to keep this field in the table because it is used in the internal version of LPVS, and we want to use open source version internally.
There was a problem hiding this comment.
Thanks for pointing that out. You're absolutely right; we're not using it right now. However, after discussing it internally, we've decided to keep it as an option in case we need it in the future.
quswjdgma83
added a commit
to kyudori/LPVS
that referenced
this pull request
Oct 16, 2023
…ayed on the page(Samsung#211) Signed-off-by: ByunJeongHeum <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]>
quswjdgma83
added a commit
to quswjdgma83/LPVS
that referenced
this pull request
Oct 16, 2023
Signed-off-by: ByunJeongHeum <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]>
quswjdgma83
added a commit
to quswjdgma83/LPVS
that referenced
this pull request
Oct 16, 2023
) Signed-off-by: ByunJeongHeum <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]>
15 tasks
quswjdgma83
added a commit
to quswjdgma83/LPVS
that referenced
this pull request
Oct 16, 2023
Signed-off-by: ByunJeongHeum <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]>
o-kopysov
pushed a commit
that referenced
this pull request
Oct 17, 2023
* style: History)style.css - Add style for dropdown(#211) Signed-off-by: ByunJeongHeum <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]> * feat: History.jsx - Add function for flexible amount of Scan(#211) Signed-off-by: ByunJeongHeum <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]> * style: History)style.css - Add style for dropdown(#211) Signed-off-by: ByunJeongHeum <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]> * edit minor bug Signed-off-by: ByunJeongHeum <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]> * Include review, Correct navigation bar errors. Signed-off-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]> * Include Review, Move DropBox. Signed-off-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]> * Remove unnessary svg File. Signed-off-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]> * Remove unnessary empty space. Signed-off-by: Han Kyuhyun <[email protected]> Co-authored-by: ByunJeongHeum <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]> --------- Signed-off-by: ByunJeongHeum <[email protected]> Signed-off-by: Han Kyuhyun <[email protected]> Co-authored-by: Han Kyuhyun <[email protected]> Co-authored-by: June Saehwan <[email protected]> Co-authored-by: jongmin Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix json parser in order to proceed with empty license array.
Removed "null" string at the end of comment message in case if no Hub Link in webhook request.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Below is just an example and you can delete it when you contribute.
Test Configuration:
Checklist: