Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: History page(Add dropdown function) #250

Merged
merged 8 commits into from
Oct 17, 2023
Merged

feat: History page(Add dropdown function) #250

merged 8 commits into from
Oct 17, 2023

Conversation

quswjdgma83
Copy link
Contributor

@quswjdgma83 quswjdgma83 commented Oct 16, 2023 •
edited
Loading

Description

"This Pull Request is linked to Issue #221. I have developed a feature that allows users to adjust the quantity of scanned data using a dropdown method.
Fixes #221

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

How Has This Been Tested?

  1. Update environment variables of docker-compose.yml, src/main/resources/application.properties, frontend/.env file.

  2. Build the lpvs container : docker compose build

  3. Run containers: docker compose up

  4. See the lpvs home page with any browser: http://localhost:7896

image

Test Configuration:

  • Java: v11
  • LPVS Release: v1.1.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

quswjdgma83 and others added 2 commits October 16, 2023 21:42
@quswjdgma83 @kyudori
@hwan5180 @Basaeng
style: History)style.css - Add style for dropdown(Samsung#211)
3ea05cb 
Signed-off-by: ByunJeongHeum <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@quswjdgma83 @kyudori
@hwan5180 @Basaeng
feat: History.jsx - Add function for flexible amount of Scan(Samsung#211
f269e26 
)

Signed-off-by: ByunJeongHeum <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@quswjdgma83 @kyudori
@hwan5180 @Basaeng
style: History)style.css - Add style for dropdown(Samsung#211)
28bcd72 
Signed-off-by: ByunJeongHeum <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@quswjdgma83 @kyudori
@hwan5180 @Basaeng
edit minor bug
8dc5520 
Signed-off-by: ByunJeongHeum <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@quswjdgma83 quswjdgma83 reopened this Oct 16, 2023
@tiokim tiokim added the enhancement New feature or request label Oct 16, 2023
@tiokim tiokim changed the title feat/#211 History page(Add dropdown function) feat: History page(Add dropdown function) Oct 16, 2023
tiokim
tiokim reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@tiokim tiokim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about removing the box that wraps around My Option?

image

frontend/src/pages/History.jsx Outdated Show resolved Hide resolved
frontend/src/pages/History.jsx Outdated Show resolved Hide resolved
frontend/src/pages/History.jsx Outdated Show resolved Hide resolved
frontend/src/pages/History.jsx Outdated Show resolved Hide resolved
kyudori and others added 2 commits October 17, 2023 10:11
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Include review, Correct navigation bar errors.
a9ef60f 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Include Review, Move DropBox.
b9c669e 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
@kyudori
Copy link
Contributor

kyudori commented Oct 17, 2023

What about removing the box that wraps around My Option?

Remove MyOptionBox and Move DropdownBox.
image

@kyudori @quswjdgma83
@hwan5180 @Basaeng
Remove unnessary svg File.
c855a9a 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
tiokim
tiokim approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your diligent contributions on LPVS!

frontend/src/css/History_style.css Outdated Show resolved Hide resolved
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Remove unnessary empty space.
3cc889b 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: jongmin Lee <[email protected]>
o-kopysov
o-kopysov approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@o-kopysov o-kopysov merged commit 2619f06 into Samsung:main Oct 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyudori kyudori kyudori left review comments

@o-kopysov o-kopysov o-kopysov approved these changes

@tiokim tiokim tiokim approved these changes

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees

@quswjdgma83 quswjdgma83

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How about to use a flexible amount of scans that can be displayed on the page?
4 participants
@quswjdgma83 @kyudori @tiokim @o-kopysov