Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add login page #209

Merged
merged 17 commits into from
Sep 13, 2023
Merged

Add login page #209

merged 17 commits into from
Sep 13, 2023

Conversation

kyudori
Copy link
Contributor

@kyudori kyudori commented Sep 9, 2023 •
edited by tiokim
Loading

Description

LPVS Front-End Login Page.
User, History, and Dashboard pages will be uploaded.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

How Has This Been Tested?

For using social login with Naver, Kakao, and Google, fill the necessary information:

  • Update the application.properties located in src/main/resources:

Enter client-id and client-secret. (Kakao doesn't require a client-secret.)
Naver: https://developers.naver.com/products/login/api/api.md
Kakao: https://developers.kakao.com/docs/latest/ko/kakaologin/common
Google: https://cloud.google.com/identity-platform/docs/web/google

  • Update the .env file located in frontend:

Enter your REST_API_KEY.

cd frontend
npm install
npm start
  1. Use Chrome to navigate to http://localhost:3000
    home
  2. On the Home Page, click Login in the upper right corner.
  3. You can login to any of the three places you want, Naver, Kakao, and Google.
    Login
  4. After logged in, you can check your name in the upper right corner of the Home Page.
    home_login

Test Configuration:

  • Java: v11
  • LPVS Release: v1.1.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

kyudori and others added 5 commits September 6, 2023 20:33
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Add Login Page.
7d042ab 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: Jongmin Lee <[email protected]>
@kyudori
Merge branch 'Samsung:main' into login
6286956
@Basaeng @kyudori
@quswjdgma83 @hwan5180
Add backend login logic
100ac8d 
Signed-off-by: jongmin Lee <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
@Basaeng @kyudori
@quswjdgma83 @hwan5180
Add backend login logic.
19f3cda 
Signed-off-by: Jongmin Lee <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
@kyudori @Basaeng
@hwan5180 @quswjdgma83
Add Header, Fixed a login error on the backend.
c1080d4 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: Jongmin Lee <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
tiokim
tiokim reviewed Sep 11, 2023
View reviewed changes
frontend/src/css/Home_style.css Outdated Show resolved Hide resolved
src/main/resources/database_dump.sql Outdated Show resolved Hide resolved
@hwan5180 @kyudori
@quswjdgma83 @Basaeng
Corrected typing typo.
9dc8ca3 
Signed-off-by: June Saehwan <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: Jongmin Lee <[email protected]>
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Remove unnecessary comment.
88dbaa3 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: Jongmin Lee <[email protected]>
@tiokim tiokim requested a review from m-rudyk September 11, 2023 10:43
hwan5180 and others added 2 commits September 12, 2023 10:37
@hwan5180 @kyudori
@quswjdgma83 @Basaeng
Edit Home_style.css, Login_style.css
6cf498a 
Signed-off-by: June Saehwan <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: Jongmin Lee <[email protected]>
@hwan5180
Merge branch 'login' of https://github.com/kyudori/LPVS into login
728a525
tiokim
tiokim approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Login with Google was successful. It needs some more revisions here and there, but it looks good to me now.

image

frontend/src/pages/Login.jsx Outdated Show resolved Hide resolved
src/main/resources/application.properties Outdated Show resolved Hide resolved
hwan5180 and others added 2 commits September 12, 2023 14:30
@hwan5180 @kyudori
@quswjdgma83 @Basaeng
Remove svg code and Edit profile name length.
811c534 
Signed-off-by: June Saehwan <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: Jongmin Lee <[email protected]>
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Edit Login Configuration
99d8ea6 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: Jongmin Lee <[email protected]>
@tiokim tiokim closed this Sep 12, 2023
@tiokim tiokim reopened this Sep 12, 2023
m-rudyk
m-rudyk approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my remark and suggestions. Otherwise, approved.

Basaeng and others added 6 commits September 12, 2023 20:12
@Basaeng
apply review
fc75c2e
@kyudori
Add Header
81d1745 
Signed-off-by: Han Kyuhyun <[email protected]>
@kyudori
Remove unnessary code.
20d7d16 
Signed-off-by: Han Kyuhyun <[email protected]>
@kyudori @quswjdgma83
@hwan5180 @Basaeng
Remove unnessary code.
3c521d7 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: Jongmin Lee <[email protected]>
@Basaeng @kyudori
@quswjdgma83 @hwan5180
Combine login method.
67f58e9 
Signed-off-by: Basaeng <[email protected]>
Co-authored-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
@Basaeng
Merge branch 'login' of https://github.com/kyudori/LPVS into login
6948171
o-kopysov
o-kopysov approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiokim tiokim merged commit 57a8722 into Samsung:main Sep 13, 2023
5 checks passed
This was referenced Sep 14, 2023
Closed
Merged
Merged
@tiokim tiokim mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Basaeng Basaeng Basaeng left review comments

@tiokim tiokim tiokim approved these changes

@m-rudyk m-rudyk m-rudyk approved these changes

@o-kopysov o-kopysov o-kopysov approved these changes

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kyudori @tiokim @o-kopysov @Basaeng @m-rudyk @hwan5180