Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix login error. #213

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Fix login error. #213

merged 2 commits into from
Sep 14, 2023

Conversation

kyudori
Copy link
Contributor

@kyudori kyudori commented Sep 14, 2023 •
edited
Loading

Description

Fixed login error. #209
Created PR again due to incorrect commit.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

How Has This Been Tested?

  • frontend
cd frontend
npm install
npm start
  • backend
mvn clean install
cd target
java -jar lpvs-*.jar
  • Test image
    image

Test Configuration:

  • Java: v11
  • LPVS Release: v1.1.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@kyudori @quswjdgma83
@hwan5180 @Basaeng
Fix login error.
410adc9 
Signed-off-by: Han Kyuhyun <[email protected]>
Co-authored-by: ByunJeongHeum <[email protected]>
Co-authored-by: June Saehwan <[email protected]>
Co-authored-by: Jongmin Lee <[email protected]>
@kyudori
Fix login DB issue.
1a3057f 
Signed-off-by: Han Kyuhyun <[email protected]>
@o-kopysov o-kopysov requested a review from m-rudyk September 14, 2023 13:53
m-rudyk
m-rudyk approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes approved. Please keep in mind that we need to cover this change with Unit Tests in order to keep current coverage ratio.

o-kopysov
o-kopysov approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tiokim
tiokim approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@tiokim tiokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiokim tiokim merged commit b818268 into Samsung:main Sep 14, 2023
5 checks passed
@kyudori kyudori mentioned this pull request Sep 15, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-rudyk m-rudyk m-rudyk approved these changes

@o-kopysov o-kopysov o-kopysov approved these changes

@tiokim tiokim tiokim approved these changes

@MoonkiHong MoonkiHong Awaiting requested review from MoonkiHong MoonkiHong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kyudori @tiokim @o-kopysov @m-rudyk