Skip to content

added generaterandomcontract function #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshalpatel165 wants to merge 18 commits into
base: dev
Choose a base branch
from
Open

added generaterandomcontract function #426

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e2284d2
added generaterandomcontract and containspublickey functions
harshalpatel165 Oct 30, 2019
8ed5ff7
changes to randomcontract function
harshalpatel165 Oct 30, 2019
171ed51
changes to randomcontract function
harshalpatel165 Oct 30, 2019
308d102
changes to randomcontract function
harshalpatel165 Oct 30, 2019
7be827d
more changes to randomcontract function- no snytax errors
harshalpatel165 Oct 31, 2019
098b25d
tested this on playground and works as intended
harshalpatel165 Nov 6, 2019
071041b
bypassed unnecessary error
harshalpatel165 Nov 7, 2019
dd1f0eb
removed comment
harshalpatel165 Nov 7, 2019
2d3ded8
removed error return type
harshalpatel165 Nov 8, 2019
66438e7
used math/rand to generate random values
harshalpatel165 Nov 8, 2019
8ba2b33
fixed conflicting imports issue
harshalpatel165 Nov 8, 2019
91fd671
fixed issues
harshalpatel165 Nov 8, 2019
545e1f3
Merge branch 'dev' into generaterandomfunction
harshalpatel165 Nov 11, 2019
fec9d8a
test
harshalpatel165 Nov 11, 2019
7f88d5c
test
harshalpatel165 Nov 11, 2019
f662f84
test again
harshalpatel165 Nov 11, 2019
a6eb843
this should do it
harshalpatel165 Nov 18, 2019
a2c1d66
made it truly random, and added in the randompublic key
harshalpatel165 Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 4 additions & 26 deletions internal/contracts/contracts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,41 +278,20 @@ func (mc *JSONContract) Unmarshal() (Contract, error) {
fmt.print(c)
Copy link
Member

@kastolars kastolars Oct 30, 2019 •
edited by harshalpatel165
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove print call here

}

func (c *Contract) ContainsPublicKey(pk publickey.AurumPublicKey) (bool, error) {
if c == nil {
return false, errors.New("not nill")
}

// encode contract's sender pub key to bytes
bKey, err := publickey.Encode(c.SenderPubKey)
if err != nil{
return bytes.Equal(bKey, pk.Bytes), errors.New("failed to encode sender public key")
}
// return the comparison of the above encoding with Bytes field of pk
return bytes.Equal(bKey, pk.Bytes), nil

}

func(c *Contract) GenerateRandomContract() (Contract){

funcGenerateRandomContract() Contract{
b := rand.Read(make([]byte, 32))

genSenderPubKey := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
Copy link
Member

@kastolars kastolars Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ecdsa.GenerateKey generates a private key. You need to extract the public key from the private key

How this is done: https://github.com/SIGBlockchain/project_aurum/blob/master/internal/publickey/publickey_test.go#L56


genrecipPubKeyHash := rand.Read(make([]byte, 32))
Copy link
Member

@kastolars kastolars Oct 30, 2019 •
edited by harshalpatel165
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix camelCase format


genVersion := binary.LittleEndian.Uint16(b[:])
Copy link
Member

@kastolars kastolars Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to make sure this is never 0? The only instance New returns an error is if the version passed in is a zero.

  • Generate only nonzero numbers for version
  • Make return type be just a Contract

Copy link
Contributor Author

@harshalpatel165 harshalpatel165 Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new function returns 2 values, contract and error, so when I return a new *random contract, it also returns error

Copy link
Member

@kastolars kastolars Nov 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. We can do what you had initially: define a return variable, with its error, then just return the return variable at the end. It doesn't make much sense to generate a random contract and need to do error checks on the call.

Copy link
Contributor Author

@harshalpatel165 harshalpatel165 Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the new function already checks if the version is greater than 0. do u want it so that is doesn't make a contract with a zero value version in the first place?

Copy link
Member

@kastolars kastolars Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is exactly what I want.


genSigLen := binary.LittleEndian.Uint8(b[:]);


genSignature := rand.Read(make([]byte, genSigLen));
Copy link
Member

@kastolars kastolars Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these two Sig variables, since we don't need them in the New function


genValue := binary.LittleEndian.Uint64(b[:])

genStateNonce := binary.LittleEndian.Uint64(b[:])


c := &Contract{
return &Contract{
Version: genVersion,
SenderPubKey: genSenderPubKey,
SigLen: genSigLen,
Expand All @@ -321,7 +300,6 @@ func(c *Contract) GenerateRandomContract() (Contract){
Value: genValue,
StateNonce: genStateNonce,

}
return c, nil
}, nil
Copy link
Member

@kastolars kastolars Oct 30, 2019 •
edited by harshalpatel165
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is no need to return a nil here, since your function only returns a Contract per the signature.


}