added generaterandomcontract function #426

harshalpatel165 · 2019-10-30T22:03:33Z

kastolars · 2019-10-30T22:04:57Z

internal/contracts/contracts.go

+	fmt.print(c)
+}
+
+func (c *Contract) ContainsPublicKey(pk publickey.AurumPublicKey) (bool, error) {


Remove this function, it will be on the other branch.

kastolars · 2019-10-30T22:05:42Z

internal/contracts/contracts.go

+
+}
+
+func(c *Contract) GenerateRandomContract() (Contract){


I don't believe we need a receiver, remove it

Remove parentheses from return type

kastolars · 2019-10-30T22:06:13Z

internal/contracts/contracts.go

+	genStateNonce := binary.LittleEndian.Uint64(b[:])
+
+
+	c := &Contract{


instead of assigning c to this, just return it.

no need for pointer &

kastolars · 2019-10-30T22:06:40Z

internal/contracts/contracts.go

+		StateNonce:  genStateNonce,
+
+	}
+	return c, nil


remove this return in favor of the above change.

internal/contracts/contracts.go

kastolars · 2019-10-30T22:14:21Z

internal/contracts/contracts.go

+		Value:  genValue,
+		StateNonce:  genStateNonce,
+
+	}, nil


There is no need to return a nil here, since your function only returns a Contract per the signature.

kastolars · 2019-10-30T22:17:24Z

internal/contracts/contracts.go

 		mc.StateNonce,
 	}
 	return c, nil
+	fmt.print(c)


remove print call here

kastolars · 2019-10-30T22:27:55Z

internal/contracts/contracts.go

+func GenerateRandomContract() Contract{
+	b := rand.Read(make([]byte, 32))
+
+	genSenderPubKey := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)


ecdsa.GenerateKey generates a private key. You need to extract the public key from the private key

How this is done: https://github.com/SIGBlockchain/project_aurum/blob/master/internal/publickey/publickey_test.go#L56

kastolars · 2019-10-30T22:29:12Z

internal/contracts/contracts.go

+		Value:  genValue,
+		StateNonce:  genStateNonce,
+
+	},


Remove this comma

kastolars · 2019-10-30T22:30:39Z

internal/contracts/contracts.go

+	genValue := binary.LittleEndian.Uint64(b[:])
+	genStateNonce := binary.LittleEndian.Uint64(b[:])
+
+	return Contract{


Instead of defining the struct with Contract { ... } , leverage the New function that returns a contract, just feed it your gen_ parameters.

I can't remember, but I think it might return a pointer to a contract, in which case you'll need to adjust your return type.

kastolars · 2019-10-30T22:42:46Z

internal/contracts/contracts.go

+	genrecipPubKeyHash := rand.Read(make([]byte, 32))
+	genVersion := binary.LittleEndian.Uint16(b[:])
+	genSigLen := binary.LittleEndian.Uint8(b[:]);
+	genSignature := rand.Read(make([]byte, genSigLen));


Let's remove these two Sig variables, since we don't need them in the New function

kastolars · 2019-10-30T22:43:12Z

internal/contracts/contracts.go

+	b := rand.Read(make([]byte, 32))
+
+	genSenderPrivKey := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
+	genrecipPubKeyHash := rand.Read(make([]byte, 32))


Fix camelCase format

kastolars · 2019-10-31T04:28:09Z

internal/contracts/contracts.go

+	rand.Read(b)
+	genSenderPrivKey, _ := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
+	genRecipPubKeyHash :=  b
+	genVersion := binary.LittleEndian.Uint16(b[:])


Is there a way to make sure this is never 0? The only instance New returns an error is if the version passed in is a zero.

Generate only nonzero numbers for version

Make return type be just a Contract

The new function returns 2 values, contract and error, so when I return a new *random contract, it also returns error

I see. We can do what you had initially: define a return variable, with its error, then just return the return variable at the end. It doesn't make much sense to generate a random contract and need to do error checks on the call.

Also, the new function already checks if the version is greater than 0. do u want it so that is doesn't make a contract with a zero value version in the first place?

Yes this is exactly what I want.

harshalpatel165 · 2019-11-06T16:37:12Z

I had to use error because rand.Read returns an error

kastolars · 2019-11-06T16:47:39Z

internal/contracts/contracts.go

+
+func GenerateRandomContract() (*Contract, error){
+	b := make([]byte, 32)
+	_, err :=rand.Read(b)


When will this return a non-nil error

The read function from rand is a helper function that uses io.readfull function from. The readFull function reads the length of the bytes and returns an error if fewer bytes were read. So, if for some reason not all the bytes were read, it would return an error

If there's no identifiable reason that all the bytes will be read, then ignore the error. I don't want to approve a generate random contract function that returns any errors because that is impractical.

harshalpatel165 · 2019-11-08T15:21:59Z

not sure why jsontest file was changed

kastolars

I think after this it'll be good

kastolars · 2019-11-12T15:48:34Z

internal/contracts/contracts.go

+	min := 1
+	maxVer := 65535
+	b := make([]byte, 32)
+	mrand.Read(b)


What is the purpose of this?

kastolars · 2019-11-12T15:49:53Z

internal/contracts/contracts.go

+	maxVer := 65535
+	b := make([]byte, 32)
+	mrand.Read(b)
+	genRecipPubKeyHash := b 


Can you make this the result of the hash of a random number?

i.e. hashing.New([]byte{ someRandomNumber })

does it matter how long the number inside the byte is, as in does it matter if it is a random Uint16 or Uint64

I thought an array of bytes was multiple values, not just one singular number

does it matter how long the number inside the byte is, as in does it matter if it is a random Uint16 or Uint64

I don't think it matters. Choose whichever is easier for you

is it possible to have an array of bytes with just a single number

i thought it was an array with multiple numbers

kastolars · 2019-11-18T13:23:21Z

internal/contracts/contracts.go

+	b := make([]byte, 8)
+	binary.LittleEndian.PutUint64(b, mrand.Uint64())
+
+	genRecipPubKeyHash := hashing.New(b)


b isn't random

I tested it out on playground, and it generates a random []byte every time I call the function

added generaterandomcontract and containspublickey functions

e2284d2

kastolars requested changes Oct 30, 2019

View reviewed changes

changes to randomcontract function

8ed5ff7

harshalpatel165 commented Oct 30, 2019

View reviewed changes

internal/contracts/contracts.go Outdated Show resolved Hide resolved

harshalpatel165 commented Oct 30, 2019

View reviewed changes

internal/contracts/contracts.go Outdated Show resolved Hide resolved

kastolars requested changes Oct 30, 2019

View reviewed changes

changes to randomcontract function

171ed51

kastolars requested changes Oct 30, 2019

View reviewed changes

changes to randomcontract function

308d102

kastolars requested changes Oct 30, 2019

View reviewed changes

more changes to randomcontract function- no snytax errors

7be827d

kastolars requested changes Oct 31, 2019

View reviewed changes

tested this on playground and works as intended

098b25d

harshalpatel165 changed the title ~~added generaterandomcontract and containspublickey functions~~ added generaterandomcontract function Nov 6, 2019

kastolars reviewed Nov 6, 2019

View reviewed changes

harshalpatel165 added 3 commits November 6, 2019 21:19

bypassed unnecessary error

071041b

removed comment

dd1f0eb

removed error return type

2d3ded8

harshalpatel165 added 7 commits November 8, 2019 10:37

used math/rand to generate random values

66438e7

fixed conflicting imports issue

8ba2b33

fixed issues

91fd671

Merge branch 'dev' into generaterandomfunction

545e1f3

test

fec9d8a

test

7f88d5c

test again

f662f84

kastolars requested changes Nov 12, 2019

View reviewed changes

this should do it

a6eb843

kastolars reviewed Nov 18, 2019

View reviewed changes

made it truly random, and added in the randompublic key

a2c1d66

		genStateNonce := binary.LittleEndian.Uint64(b[:])


		c := &Contract{

added generaterandomcontract function #426

Are you sure you want to change the base?

added generaterandomcontract function #426

Uh oh!

Conversation

harshalpatel165 commented Oct 30, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastolars Oct 30, 2019 • edited by harshalpatel165 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastolars Oct 30, 2019 • edited by harshalpatel165 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastolars Oct 30, 2019 • edited by harshalpatel165 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kastolars Oct 30, 2019 • edited by harshalpatel165 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastolars Oct 30, 2019 • edited by harshalpatel165 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastolars Oct 30, 2019 • edited by harshalpatel165 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastolars Oct 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastolars Oct 30, 2019 • edited by harshalpatel165 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harshalpatel165 commented Nov 6, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

harshalpatel165 commented Nov 8, 2019

Uh oh!

kastolars left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kastolars Oct 30, 2019 •

edited by harshalpatel165

Loading

kastolars Oct 30, 2019 •

edited by harshalpatel165

Loading

kastolars Oct 30, 2019 •

edited by harshalpatel165

Loading

kastolars Oct 30, 2019 •

edited by harshalpatel165

Loading

kastolars Oct 30, 2019 •

edited by harshalpatel165

Loading

kastolars Oct 30, 2019 •

edited by harshalpatel165

Loading

kastolars Oct 30, 2019 •

edited

Loading

kastolars Oct 30, 2019 •

edited by harshalpatel165

Loading