Skip to content

Make GetXmlDocsPath public and inheritdoc cref= functionality#83

Closed
erichiller wants to merge 8 commits intoRicoSuter:masterfrom
erichiller:master
Closed

Make GetXmlDocsPath public and inheritdoc cref= functionality#83
erichiller wants to merge 8 commits intoRicoSuter:masterfrom
erichiller:master

Conversation

@erichiller
Copy link
Copy Markdown

  • Make GetXmlDocsPath public
  • add additional functionality for cref= inheritdoc
  • added .editorconfig reflecting existing formatting styles

@RicoSuter
Copy link
Copy Markdown
Owner

RicoSuter commented Jul 13, 2021

Thanks for the PR. Please clean up unused spaces and use the code style already used in the project (e.g. { on new lines) and remove the editorconfig (we use VS defaults).

@dropsonic
Copy link
Copy Markdown

@erichiller @RicoSuter are there any updates with this PR?
I faced the same issue with the non-working <inheritdoc> tag when it contains cref inside.

@RicoSuter
Copy link
Copy Markdown
Owner

In order to merge this PR:

  • Please add unit tests for the new functionality
  • Please revert the code style changes and editorconfig
  • Fix conflicts

@RicoSuter
Copy link
Copy Markdown
Owner

Thanks for the contribution! However, the functionality in this PR has since been independently implemented on master:

Since all the key changes are already covered, I'm going to close this PR.

@RicoSuter RicoSuter closed this Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants