Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make XmlDocsExtensions.GetXmlDocsPath public #75

Closed
erichiller opened this issue Apr 27, 2021 · 4 comments
Closed

Make XmlDocsExtensions.GetXmlDocsPath public #75

erichiller opened this issue Apr 27, 2021 · 4 comments

Comments

@erichiller
Copy link

It would be great if I could easily access the functionality behind XmlDocsExtensions.cs / private string GetXmlDocsPath(dynamic assembly).
@RicoSuter
Copy link
Owner

RicoSuter commented Apr 27, 2021 •
edited
Loading

Fine for me... we probably should change "dynamic" to "Assembly" if possible (need to check the reason for that). Can you create a PR?

@erichiller
Copy link
Author

Sorry for the delay, I started working on this - quick question, do you have desired style settings, or should I just use my preference?

@RicoSuter
Copy link
Owner

This should be a very small change no?
I'd try to align style with the rest of the code...

@erichiller
Copy link
Author

Sorry for the delay. I added some other functionality around using <inheritdoc cref="' />. PR #83
Let me know if anything looks off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RicoSuter @erichiller