feat(alert): persistent toast, toast actions #2170
Open
+580
−238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b60f246 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +745 B (+0.36%) Total Size: 207 kB
ℹ️ View Unchanged
|
This was
linked to
issues
Feb 17, 2025
|
Maybe this needs to be split out to its own issue. However, it was noticeable here due to the extensive custom content added to the code page. It looks like the API for
The TOC should have element links and look like this:
|
|
@zeroedin i don't think they're available on any page https://ux.redhat.com/elements/card/code/ |
Interesting, they are on https://ux.redhat.com/elements/navigation-secondary/code/ and https://ux.redhat.com/elements/accordion/code/ My assumption is due to the fact they have sub components that need documentation as well. Maybe we need an overarching "Elements API" header here? |
|
on that page though, there's no heading for |
Yup, I recognized that as well which is why I'm wondering if we need a Header above all of them to denote the whole section of element api's to follow instead of listing each individually (unless we want to go down the path of nested toc) ## Element API
### `rh-tag`
### `rh-tag-subcomponent`Either way likely out of scope to this PR. |
zeroedin
approved these changes
Feb 18, 2025
|
Can we provide a link or some sort of text to logically connect the 
Possible solution:
Thoughts? |
markcaron
requested changes
Feb 19, 2025
| | `actions` | Array of one or two actions objects | One or more optional body actions | | ||
|
|
||
| </rh-table> | ||
|
|
There was a problem hiding this comment.
Can we add a header here and link to it from the table above? I think it'll help connect the two.
| <p>Contact <a href="#">Customer support</a> for more information.</p> | ||
| </template> | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Can we add some margin between these? They look weird when they're touching.
bennypowers
force-pushed
the
feat/alert/persistent-toast
branch
from
ac9ec0e to
b60f246
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
persistent: trueoption for toast methodactions: []option for toast methodTesting Instructions
Notes to Reviewers
I think the docs could use a new Do/Don't section explaining that users should use the
toast()method and not manually add thevariant="toast"attribute.Regarding actions, I assumed in this PR that...