Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change babs init parameter --input to --datasets #230

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Change babs init parameter --input to --datasets #230

merged 4 commits into from
Mar 21, 2025
+110 −84

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Mar 20, 2025 •
edited
Loading

Related to #218.

Changes proposed:

  • Rename --input parameter to --datasets.
  • Change organization of parameter from list of two-element lists to a dictionary.
    • For example, babs init --input name1 /path1 name2 /path2 becomes babs init --datasets name1=/path1 name2=/path2.
    • It's optional to not provide the name. (e.g., babs init --datasets /path1).

@tsalo tsalo added the breaking-change PRs that change results or interfaces. label Mar 20, 2025
@tsalo tsalo requested review from mattcieslak and tientong98 March 20, 2025 19:28
@tsalo tsalo merged commit 0b57fa6 into main Mar 21, 2025
11 checks passed
@tsalo tsalo deleted the change-params branch March 21, 2025 17:23
mattcieslak pushed a commit that referenced this pull request Mar 21, 2025
@tsalo @mattcieslak
Change babs init parameter --input to --datasets (#230)
510cb31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tientong98 tientong98

@mattcieslak mattcieslak

Assignees
No one assigned
Labels
breaking-change PRs that change results or interfaces.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsalo @tientong98