feat(core-cli): tqdm , flatten properties , argument for release version #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version to argument , adds new cli command for release version Also adds method to flatten the properties when geojson is selected as a output format , black formats the code , we might need to check the release before attempting to download
|
Hi @kshitijrajsharma - Thanks for the contributions! Can you make the different functionalities as separate PRs?
|
…version to release as cli\ cli version changes and refactor for the tqdm
|
Thanks @jwass . Will do ! I understand the concern in flatten properties ! |
Feature/release ci
…ort along with tqdm Adds validation for the custom theme and type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Consideration
I couldn't add full tqdm support due to the generator in arrow dataset as it doesn't provide whats the total batch gonna be in advance , May be something to look in future . I have added new cli argument it would be good to choose version also we need to validate before attempting actual download . It will fail anyway if wrong version is supplied and it is optional so that it won't break any exisiting implementations . We need to add tests as well so that I will know if I break anything
How to test ?
WIP
Note :
PR is in draft , Work in Progress