Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : CI option release #19

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kshitijrajsharma
Copy link

@kshitijrajsharma kshitijrajsharma commented Apr 29, 2024

What does this PR do ?

Consideration :

Nothing much I have removed the flatten properties to be in separate PR and I understand this might need further followup . Hence I have only included release ci option in this PR

How to test ?

  • Currently release should be optional by default but has option that you can switch

…version to argument , adds new cli command for release version

Also adds method to flatten the properties when geojson is selected as a output format , black formats the code , we might need to check the release before attempting to download
…version to release as cli\

cli version changes and refactor for the tqdm
@kshitijrajsharma kshitijrajsharma marked this pull request as ready for review April 29, 2024 02:41
overturemaps/core.py Outdated Show resolved Hide resolved
overturemaps/cli.py Outdated Show resolved Hide resolved
@jwass
Copy link
Collaborator

jwass commented Apr 30, 2024

@kshitijrajsharma I'm curious how you are using this? I went to test this out and remembered that older releases of Overture had the bbox as minx, miny, etc. instead of xmin, ymin so this will crash on any release other than the recent 2024-04-16-beta.0 release.

Multiple releases gets tricky as we'd have to know how to convert the input bbox to the appropriate filter... although it's unlikely to change going forward.

@kshitijrajsharma
Copy link
Author

@kshitijrajsharma I'm curious how you are using this? I went to test this out and remembered that older releases of Overture had the bbox as minx, miny, etc. instead of xmin, ymin so this will crash on any release other than the recent 2024-04-16-beta.0 release.

Multiple releases gets tricky as we'd have to know how to convert the input bbox to the appropriate filter... although it's unlikely to change going forward.

you are correct ! I am targeting more on future releases. I hope overture will have a consistent way of querying them. So that whenever there is new release we don't have to hardcode and update the python package !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for choice of dataset version ?
2 participants