-
Notifications
You must be signed in to change notification settings - Fork 69
Guiding and perf fixes #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ClutchplateDude
commented
Feb 21, 2025
- Improved Serial command handling (made it less 'blocking'), which should improve general performance
- Guiding now updates RA/DEC coordinates
- Guide pulses are ignored when tracking is disabled (for example, when at the limits)
Serial handling was blocking until timeout (1s), which made sub 1s guiding near impossible (!).
# Conflicts: # src/Mount.cpp # src/f_serial.hpp
Looks like your PR has code that needs to be changed in order to meet our coding standards!
|
- Improved Serial command handling (made it less 'blocking'), which should improve general performance - Guiding now updates RA/DEC coordinates - Guide pulses are ignored when tracking is disabled (for example, when at the limits)
julianneswinoga
previously approved these changes
Mar 8, 2025
julianneswinoga
approved these changes
Mar 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.