Skip to content

Guiding and perf fixes #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 8, 2025
Merged

Guiding and perf fixes #261

merged 9 commits into from
Mar 8, 2025

Conversation

ClutchplateDude
Copy link
Member

  • Improved Serial command handling (made it less 'blocking'), which should improve general performance
  • Guiding now updates RA/DEC coordinates
  • Guide pulses are ignored when tracking is disabled (for example, when at the limits)

Serial handling was blocking until timeout (1s), which made sub 1s guiding near impossible (!).
# Conflicts:
#	src/Mount.cpp
#	src/f_serial.hpp
@openastrotech-bot
Copy link
Contributor

Looks like your PR has code that needs to be changed in order to meet our coding standards!
Here are your options:

  1. Apply the patch that was generated by the job
    1. Click details under the failing clang-format check
    2. Click the Artifacts dropdown in the top right
    3. Download + unzip the clang-format-diff.patch file into the OpenAstroTracker-Firmware repo
    4. Run git apply clang-format-diff.patch to make the changes
    5. Commit and push up the formatted code
  2. Run clang-format locally
    1. Run the command bash -c 'shopt -s nullglob globstar;GLOBIGNORE=./src/libs/TimerInterrupt/*; for i in ./{.,src/**,unit_tests,boards/**}/*.{c,cpp,h,hpp}; do clang-format -i $i; done'
    2. Commit and push up the formatted code

- Improved Serial command handling (made it less 'blocking'), which should improve general performance
- Guiding now updates RA/DEC coordinates
- Guide pulses are ignored when tracking is disabled (for example, when at the limits)
julianneswinoga
julianneswinoga previously approved these changes Mar 8, 2025
@ClutchplateDude ClutchplateDude merged commit 3550d53 into develop Mar 8, 2025
8 checks passed
@ClutchplateDude ClutchplateDude deleted the guiding-fixes branch March 8, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants