PR Feedback

Author: ClutchplateDude

src/HallSensorHoming.cpp

@@ -210,6 +210,7 @@ void HallSensorHoming::processHomingProgress()
                         {
                             // First time the pin has triggered, record that position
                             _homingData.position[HOMING_START_PIN_POSITION] = _pMount->getCurrentStepperPosition(_axis);
+
                             LOG(DEBUG_STEPPERS,
                                 "[HOMING]: Potentially found start of sensor at %l",
                                 _homingData.position[HOMING_START_PIN_POSITION]);
@@ -230,6 +231,10 @@ void HallSensorHoming::processHomingProgress()
                             // Make sure we continue moving far enough to reach end
                             long distance = _homingData.initialDir * _stepsPerDegree * _homingData.searchDistance;
                             _pMount->moveStepperBy(_axis, distance);
+                            LOG(DEBUG_STEPPERS,
+                                "[HOMING]: Making sure stepper keeps going by another %l steps. New target is %l",
+                                distance,
+                                _pMount->getCurrentStepperPosition(_axis) + distance);
 
                             _homingData.lastPinState   = homingPinState;
                             _homingData.pinChangeCount = 0;
@@ -289,6 +294,10 @@ void HallSensorHoming::processHomingProgress()
                             // Make sure we continue moving far enough to reach end
                             long distance = -_homingData.initialDir * _stepsPerDegree * _homingData.searchDistance;
                             _pMount->moveStepperBy(_axis, distance);
+                            LOG(DEBUG_STEPPERS,
+                                "[HOMING]: Making sure stepper keeps going by another %l steps. New target is %l",
+                                distance,
+                                _pMount->getCurrentStepperPosition(_axis) + distance);
 
                             _homingData.lastPinState   = homingPinState;
                             _homingData.pinChangeCount = 0;

src/f_serial.hpp

@@ -16,7 +16,6 @@ void processSerialData();
 // The main loop when under serial control
 void serialLoop()
 {
-    //Serial.print('.');
     mount.loop();
     mount.displayStepperPositionThrottled();
 
@@ -126,36 +125,33 @@ void processSerialData()
         #endif
                 index = 0;
             }
-            else
+            else if (buffer[index] == '#')
             {
-                if (buffer[index] == '#')
-                {
-                    // Ignoring trailing hash
-                    buffer[index] = 0;
-                    String inCmd  = String(buffer);
-                    LOG(DEBUG_SERIAL, "[SERIAL]: ReceivedCommand(%d chars): [%s]", inCmd.length(), inCmd.c_str());
+                // Ignoring trailing hash
+                buffer[index]      = '\0';
+                const String inCmd = String(buffer);
+                LOG(DEBUG_SERIAL, "[SERIAL]: ReceivedCommand(%d chars): [%s]", inCmd.length(), inCmd.c_str());
 
-                    String retVal = MeadeCommandProcessor::instance()->processCommand(inCmd);
-                    if (retVal != "")
-                    {
-                        LOG(DEBUG_SERIAL, "[SERIAL]: RepliedWith:  [%s]", retVal.c_str());
-                            // When not debugging, print the result to the serial port .
-                            // When debugging, only print the result to Serial if we're on seperate ports.
+                const String retVal = MeadeCommandProcessor::instance()->processCommand(inCmd);
+                if (retVal != "")
+                {
+                    LOG(DEBUG_SERIAL, "[SERIAL]: RepliedWith:  [%s]", retVal.c_str());
+                        // When not debugging, print the result to the serial port .
+                        // When debugging, only print the result to Serial if we're on seperate ports.
         #if (DEBUG_LEVEL == DEBUG_NONE) || (DEBUG_SEPARATE_SERIAL == 1)
-                        Serial.print(retVal);
+                    Serial.print(retVal);
         #endif
-                    }
-                    // Wait for next command
-                    index = 0;
                 }
-                else if (buffer[index] > 31)
+                // Wait for next command
+                index = 0;
+            }
+            else if (buffer[index] >= ' ')
+            {
+                index++;
+                if (index >= sizeof(buffer))
                 {
-                    index++;
-                    if (index >= sizeof(buffer))
-                    {
-                        LOG(DEBUG_SERIAL, "[SERIAL]: Command buffer overflow! Ignoring received data.");
-                        index = 0;
-                    }
+                    LOG(DEBUG_SERIAL, "[SERIAL]: Command buffer overflow! Ignoring received data.");
+                    index = 0;
                 }
             }
         }