Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Encode list query parameters for python pydantic v1 client #20614

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

joostsijm
Copy link
Contributor

@cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

I'd like to apply the same solution as PR #20148 for the Python Pydantic v1 generator and have not been able to do a successful build.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Feb 17, 2025

https://github.com/OpenAPITools/openapi-generator/actions/runs/13201325996/job/37336001483?pr=20614

please update the samples so that CI can test the change

@wing328
Copy link
Member

wing328 commented Feb 18, 2025

python tests with updated samples passed via #20677

@wing328 wing328 merged commit 5687edc into OpenAPITools:master Feb 18, 2025
30 of 31 checks passed
@wing328
Copy link
Member

wing328 commented Feb 18, 2025

FYI. Samples updated via 8fb81ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants