-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade code to use openapi-generator-cli v7.0.1.1 #8652
Conversation
- Update fixes from v7.0.1 - Apply patch for python - Encode list query params (#20148)[OpenAPITools/openapi-generator#20148] - Minor Python markdown spaces for the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried that I might be missing something as this is a big change.
Here's my proposal:
Lets try to do it iteratively. By that I mean lets start with updating only the open API generator image for the python client. This way we reduce the risk to introduce breaking changes into the Java client.
We can then test the python client intensively (suggest to start by running the python wrapper unit and integration tests using that client).
WDYT?
@N-o-Z nothing to worry about the change the Java SDK - it was just removing unused import If there was an easy way to do tell the diff - hide this change from all files, it would make generated code review much easier. Will look into check the original issue that was opened for the python sdk and the conflict that I am more worried about as it seems that the generated code was modified. |
@nopcoder running the python wrapper utests using the new SDK code I get the following error:
|
@N-o-Z fixed the generator image, pushed a fix to this branch and tested utests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified Python wrapper utests and integration tests with new SDK
Thanks for the support. FYI, also submitted a solution quote bug to the OpenAPI-generator python-pydantic-v1 generator, which has been merged: OpenAPITools/openapi-generator#20614 |
Close #8558