Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/safe module #107
base: main
Are you sure you want to change the base?
Feat/safe module #107
Changes from all commits
35d5ad8
4970baf
a5eef60
5b26779
a96702c
e8c73d9
8a219a6
f976d07
2c7df8a
3dde397
765d974
c224748
dea7cb1
a6bb0da
784ab37
7181fef
03d831c
65cf91d
7590760
84e6025
1cee2cd
aab0b55
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we calculate at how many contributors might this break with 2100 gas, because the free gas in a
receive
is lower than the allocation of a new storage slot to write down their contribution?We don't have to worry about fallback() when receive() is set, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not we don't have to worry about fallback()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2100 gas limit doesn't hold here. Any interaction via
transfer/send
will revert with OOG