Feat/safe module #107
Open
Feat/safe module #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samparsky
force-pushed
the
feat/safe-module
branch
from
fb11745
to
a6bb0da
Compare
OisinKyne
approved these changes
Dec 6, 2023
| depositContract = IETH2DepositContract(eth2DepositContract); | ||
| } | ||
|
|
||
| receive() external payable { |
There was a problem hiding this comment.
Should we calculate at how many contributors might this break with 2100 gas, because the free gas in a receive is lower than the allocation of a new storage slot to write down their contribution?
We don't have to worry about fallback() when receive() is set, yes?
There was a problem hiding this comment.
not we don't have to worry about fallback()
There was a problem hiding this comment.
The 2100 gas limit doesn't hold here. Any interaction via transfer/send will revert with OOG
| handler.ghost_depositSum() - mockDepositContract.ghost_depositSum() - handler.ghost_rageQuitSum() | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
I don't really understand this testing much, walk me through it on our next one on one call :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91