Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest version of ReSpec #239

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

ralfhandl
Copy link
Contributor

  • package.json
    • make respec a pinned dependency
  • build.sh
    • copy installed respec version to deploy folder during build, remove afterwards
    • build static HTML file that does not require respec-x.js at runtime
  • md2html.js
    • adjusted respec config
    • adjusted "frontmatter" sections to work with new respec
    • adjusted normative references: [[RFC3986]] instead of [[!RFC3986]]
    • adjusted link targets to use <span id= instead of the deprecated <a name=

New build output: https://ralfhandl.github.io/OpenAPI-Specification/arazzo/latest.html

@ralfhandl
Copy link
Contributor Author

@frankkilcommins Please review

Copy link
Collaborator

@frankkilcommins frankkilcommins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @ralfhandl

LGTM!

@ralfhandl
Copy link
Contributor Author

@frankkilcommins Thanks!

I don't have merge rights for this repo, so could you please merge?

@frankkilcommins
Copy link
Collaborator

@ralfhandl - will add it to the list of PRs for review during our session this Wednesday.

Copy link
Collaborator

@ndenny ndenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frankkilcommins frankkilcommins merged commit 0614858 into OAI:main Aug 28, 2024
1 check passed
frankkilcommins added a commit that referenced this pull request Aug 28, 2024
* Minor example updates from linter (#215)

* Update ReadMe images (#229)

* chore: fix double pipe rendering for respec

* chore: update images on the repo ReadMe

* Use latest respec (#239)

---------

Co-authored-by: Lorna Jane Mitchell <[email protected]>
Co-authored-by: Ralf Handl <[email protected]>
@ralfhandl ralfhandl deleted the use-latest-respec branch August 28, 2024 17:01
frankkilcommins added a commit that referenced this pull request Oct 23, 2024
* Minor example updates from linter (#215)

* Update ReadMe images (#229)

* chore: fix double pipe rendering for respec

* chore: update images on the repo ReadMe

* Use latest respec (#239)

---------

Co-authored-by: Lorna Jane Mitchell <[email protected]>
Co-authored-by: Ralf Handl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants