Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #26514: Change validation and global settings navigation menu got merged #6267

Open
wants to merge 1 commit into
base: branches/rudder/8.3
Choose a base branch
from

Conversation

RaphaelGauthier
Copy link
Member

@RaphaelGauthier RaphaelGauthier commented Mar 20, 2025

https://issues.rudder.io/issues/26514

The buildScrollSpyNav function now takes 2 parameters:

  • the navbar identifier, so as not to override another navbar
  • the identifier of the container that contains the titles linked to this menu

Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it works, but the change-validation settings CSS and scroll height looks broken, it will need to be fixed in the plugins repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants