Fixes #26583: Navbar menu is broken #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
reviewed
Mar 21, 2025
There was a problem hiding this comment.
👍 LGTM, the menu is appearing and it fixes previous display issues after Normation/rudder#6267
But the menu navigation is broken (which is not so problematic, we can fix it later), one annoying thing is that the page is cut before the end, the scroll is not reaching the bottom :
If you think it cannot be fixed easily, this PR can be merged and we can always do it later
|
I'm for merging this one. We're just too near to the RC to wait on non blocking errors. |
fanf
approved these changes
Mar 24, 2025
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/26583
Before:
After:
