-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update default mock_NWBFile start time #2018
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2018 +/- ##
=======================================
Coverage 91.73% 91.73%
=======================================
Files 27 27
Lines 2722 2722
Branches 710 710
=======================================
Hits 2497 2497
Misses 149 149
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
[Edit] |
@h-mayorquin Good idea but let's open a separate issue for that since it will probably require editing code all over the place |
lgtm but I'm also interested in @rly 's take on this |
Co-authored-by: Ryan Ly <[email protected]>
Motivation
Fix #2013. There was an error when creating a
mock_NWBFile
in specific time zones, where converting the default start time to local time would result in a time before the Unix epoch.The default could also be updated to any later time, I left as 1970 for now in case that is used to indicate this is mock data.
I don't think these changes require a CHANGELOG update but can add if needed.
How to test the behavior?
Checklist
ruff check . && codespell
from the source directory.