Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support and documentation for export from HDMF version 2 #1280

Merged
merged 16 commits into from
Aug 13, 2020
Merged

Add support and documentation for export from HDMF version 2 #1280

merged 16 commits into from
Aug 13, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Aug 12, 2020

Motivation

See hdmf-dev/hdmf#388

I also changed the docval for NWBHDF5IO.export from what it was for HDF5IO.export:

HDF5IO.export(path=..., container=...)
NWBHDF5IO.export(path=..., nwbfile=...)

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number?

@rly rly requested review from ajtritt, bendichter and oruebel August 12, 2020 08:24
oruebel
oruebel previously approved these changes Aug 12, 2020
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the minor comment the tutorial description this looks good.

@rly rly requested a review from oruebel August 13, 2020 00:20
@rly
Copy link
Contributor Author

rly commented Aug 13, 2020

@oruebel I made the suggested changes and added another section on Object IDs

@rly rly merged commit 4eb8468 into dev Aug 13, 2020
@rly rly deleted the export branch August 13, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants