Skip to content

Commit

Permalink
rmv s3fs dependency (#549)
Browse files Browse the repository at this point in the history
* rmv s3fs dependency

* Update CHANGELOG.md

* Add s3fs dependency to read-nwbfile-tests workflow
  • Loading branch information
bendichter authored Jan 9, 2025
1 parent fc516f3 commit fc7491b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/read-nwbfile-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
pip install pytest-cov
- name: Install package
run: pip install ".[dandi]"
run: pip install ".[dandi]" s3fs

- name: Uninstall h5py
run: pip uninstall -y h5py
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Upcoming

### Deprecation
* Remove s3fs dependency, which was causing dependency management issues [#549](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/549)

## Improvements
* Added a section for describing the issues with negative timestamps in `TimeSeries` [#545](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/545)
Expand Down
3 changes: 1 addition & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ dependencies = [
"pynwb>=2.8,<3", # NWB Inspector should always be used with most recent minor versions of PyNWB
"hdmf-zarr",
"fsspec",
"s3fs",
"requests",
"aiohttp",
"PyYAML",
Expand Down Expand Up @@ -63,7 +62,7 @@ nwbinspector = "nwbinspector._nwbinspector_cli:_nwbinspector_cli"

[tool.black]
line-length = 120
target-version = ['py37']
target-version = ['py39']
include = '\.pyi?$'
extend-exclude = '''
/(
Expand Down

0 comments on commit fc7491b

Please sign in to comment.