Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: allocate port for timescale #44

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Update: allocate port for timescale #44

merged 4 commits into from
Oct 10, 2024

Conversation

gsanchietti
Copy link
Member

@gsanchietti gsanchietti commented Oct 8, 2024

The new tunadm,portsadm role is required to manage tun devices and port allocation

NethServer/dev#7035

The new tunadm,portsadm role is required to manage tun devices
and port allocation
Port allocations is part of core 3.1.0
@gsanchietti gsanchietti force-pushed the port_allocation branch 3 times, most recently from 4cea349 to d32ae3a Compare October 9, 2024 13:08
On update, if the number of port is not enough:

- allocate port for Timescale
- create db.env
@gsanchietti gsanchietti changed the title build: change role for port allocation Update: allocate port for timescale Oct 10, 2024
@gsanchietti gsanchietti marked this pull request as ready for review October 10, 2024 08:11
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect to see the new TCP_PORT_DB assigned for new installations too. Is it ouside this PR?

@gsanchietti
Copy link
Member Author

I'd expect to see the new TCP_PORT_DB assigned for new installations too. Is it ouside this PR?

I thought about it, I can add it but it has no real use.
On the other hand, having it only on updated instance can be used in the future as flag

@gsanchietti
Copy link
Member Author

Can I proceed with the merge and move it to testing @DavidePrincipi ?

Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but you'll need also NethServer/ns8-core#728 to test this one,

@gsanchietti
Copy link
Member Author

Yes, I know and I can write it down inside the test case

@gsanchietti gsanchietti merged commit d7ca92d into main Oct 10, 2024
1 check passed
@gsanchietti gsanchietti deleted the port_allocation branch October 10, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants