Port allocation: allow to keep existing range #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsanchietti
force-pushed
the
add_port
branch
3 times, most recently
from
9645b35
to
a8e873d
Compare
gsanchietti
changed the title
If keep_existing option is set, current allocated range is not deleted: another range is added to the existing one Without reallocating the whole range, this option can simplify the configuration of modules that are using many ports.
tommaso-ascani
approved these changes
Oct 11, 2024
The allocate_ports and deallocate_ports can't be compared because they now are different types: range vs list of ranges.
DavidePrincipi
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve existing allocate port method to ease the update of complex modules.
Issue referencec:
Tested with NethSecurity Controller update: NethServer/ns8-nethsecurity-controller#44