Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New ports allocation system #699

Merged
merged 18 commits into from
Oct 7, 2024
Merged

New ports allocation system #699

merged 18 commits into from
Oct 7, 2024

Conversation

tommaso-ascani
Copy link
Contributor

This new feature implements a new ports allocation system through a library to allocate, deallocate, reallocate ports.
Were also implemented some node APIs to let the module use the library.

NethServer/dev#6974

github-actions bot pushed a commit that referenced this pull request Sep 2, 2024
@nethbot
apidoc@feature-6974-1 #699
8249623
github-actions bot pushed a commit that referenced this pull request Sep 3, 2024
@nethbot
apidoc@feature-6974-1 #699
a95591c
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
@nethbot
apidoc@feature-6974-1 #699
ff58d2c
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
@nethbot
apidoc@feature-6974-1 #699
79a433e
@tommaso-ascani tommaso-ascani marked this pull request as ready for review September 4, 2024 15:24
DavidePrincipi
DavidePrincipi reviewed Sep 9, 2024
View reviewed changes
core/imageroot/usr/local/agent/pypkg/node/ports_manager.py Outdated Show resolved Hide resolved
core/imageroot/usr/local/agent/pypkg/node/ports_manager.py Outdated Show resolved Hide resolved
core/imageroot/usr/local/agent/pypkg/node/ports_manager.py Outdated Show resolved Hide resolved
core/imageroot/usr/local/agent/pypkg/node/ports_manager.py Outdated Show resolved Hide resolved
docs/modules/port_allocation.md Outdated Show resolved Hide resolved
docs/modules/port_allocation.md Outdated Show resolved Hide resolved
docs/modules/port_allocation.md Outdated Show resolved Hide resolved
core/imageroot/var/lib/nethserver/node/actions/deallocate-ports/50deallocate Show resolved Hide resolved
core/imageroot/var/lib/nethserver/node/actions/allocate-ports/50allocate Show resolved Hide resolved
docs/modules/port_allocation.md Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
@nethbot
apidoc@feature-6974-1 #699
fbc24ee
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
@nethbot
apidoc@feature-6974-1 #699
58e75e1
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@nethbot
apidoc@feature-6974-1 #699
934a67d
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@nethbot
apidoc@feature-6974-1 #699
f8b9a59
DavidePrincipi
DavidePrincipi approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but before merging this PR, we need to release some bug fixes.

github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@nethbot
apidoc@feature-6974-1 #699
b77b74a
github-actions bot pushed a commit that referenced this pull request Sep 17, 2024
@nethbot
apidoc@feature-6974-1 #699
1258bcf
DavidePrincipi
DavidePrincipi reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please in the "Agent library" section, draw a scenario where the library calls are useful. For example: when an application introduces a new feature at a certain point and needs more TCP ports.

docs/modules/port_allocation.md Outdated Show resolved Hide resolved
docs/modules/port_allocation.md Outdated Show resolved Hide resolved
docs/modules/port_allocation.md Outdated Show resolved Hide resolved
docs/modules/port_allocation.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Sep 19, 2024
@nethbot
apidoc@feature-6974-1 #699
562b6c7
github-actions bot pushed a commit that referenced this pull request Sep 19, 2024
@nethbot
apidoc@feature-6974-1 #699
107ba42
DavidePrincipi
DavidePrincipi reviewed Sep 19, 2024
View reviewed changes
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make module_id argument optional

core/imageroot/usr/local/agent/pypkg/agent/__init__.py Outdated Show resolved Hide resolved
docs/modules/port_allocation.md Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Sep 19, 2024
@nethbot
apidoc@feature-6974-1 #699
42f8e40
github-actions bot pushed a commit that referenced this pull request Sep 27, 2024
@nethbot
apidoc@feature-6974-1 #699
2d3b59c
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@nethbot
apidoc@feature-6974-1 #699
03f11f7
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@nethbot
apidoc@feature-6974-1 #699
cdbec33
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@nethbot
apidoc@feature-6974-1 #699
b89a461
@tommaso-ascani
Some fix:
26eb57c 
- EXCLUSIVE connection
- Retry time
- Changed default value in write_range function
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@nethbot
apidoc@feature-6974-1 #699
6ef3a56
github-actions bot pushed a commit that referenced this pull request Oct 2, 2024
@nethbot
apidoc@feature-6974-1 #699
39a05fc
DavidePrincipi
DavidePrincipi approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to resume testing.

github-actions bot pushed a commit that referenced this pull request Oct 7, 2024
@nethbot
apidoc@feature-6974-1 #699
cebedda
@DavidePrincipi DavidePrincipi merged commit 1e9dcda into main Oct 7, 2024
3 checks passed
@DavidePrincipi DavidePrincipi deleted the feature-6974-1 branch October 7, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidePrincipi DavidePrincipi DavidePrincipi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tommaso-ascani @DavidePrincipi