Apply suggestions from code review

Co-authored-by: Davide Principi <[email protected]>
NethServer · Sep 17, 2024 · c6fb08f · c6fb08f
1 parent c799749
commit c6fb08f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/core/imageroot/var/lib/nethserver/node/actions/allocate-ports/50allocate b/core/imageroot/var/lib/nethserver/node/actions/allocate-ports/50allocate
@@ -16,7 +16,7 @@ request = json.load(sys.stdin)
 module_env = os.getenv("AGENT_TASK_USER")
 
 if module_env != "" and module_env != f"module/{request['module_id']}":
-    print(agent.SD_ERR + f"Agent {module_env} do not have permission to change port allocation for another module.")
+    print(agent.SD_ERR + f"Agent {module_env} does not have permission to change the port allocation for {request['module_id']}.")
     sys.exit(1)
 
 range = node.ports_manager.allocate_ports(int(request['ports']), request['module_id'], request['protocol'])

diff --git a/core/imageroot/var/lib/nethserver/node/actions/allocate-ports/validate-input.json b/core/imageroot/var/lib/nethserver/node/actions/allocate-ports/validate-input.json
@@ -18,7 +18,7 @@
         "module_id": {
             "type": "string",
             "title": "Module identifier",
-            "description": "Name of module that is asking to allocate ports"
+            "description": "Ports are allocated to the given module."
         },
         "protocol": {
             "type": "string",

diff --git a/core/imageroot/var/lib/nethserver/node/actions/deallocate-ports/50deallocate b/core/imageroot/var/lib/nethserver/node/actions/deallocate-ports/50deallocate
@@ -16,7 +16,7 @@ request = json.load(sys.stdin)
 module_env = os.getenv("AGENT_TASK_USER")
 
 if module_env != "" and module_env != f"module/{request['module_id']}":
-    print(agent.SD_ERR + f"Agent {module_env} do not have permission to change port allocation for another module.")
+    print(agent.SD_ERR + f"Agent {module_env} does not have permission to change the port allocation for {request['module_id']}.")
     sys.exit(1)
 
 range = node.ports_manager.deallocate_ports(request['module_id'], request['protocol'])

diff --git a/core/imageroot/var/lib/nethserver/node/actions/deallocate-ports/validate-input.json b/core/imageroot/var/lib/nethserver/node/actions/deallocate-ports/validate-input.json
@@ -12,7 +12,7 @@
         "module_id": {
             "type": "string",
             "title": "Module identifier",
-            "description": "Name of module that is asking to deallocate ports"
+            "description": "Ports are deallocated from the given module."
         },
         "protocol": {
             "type": "string",