Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook paths #59

Closed
wants to merge 0 commits into from
Closed

Fix notebook paths #59

wants to merge 0 commits into from

Conversation

andersy005
Copy link
Contributor

Fixes the half-baked #58

@andersy005 andersy005 requested a review from a team as a code owner April 15, 2020 04:25
@andersy005 andersy005 marked this pull request as draft April 15, 2020 04:25
@kmpaul
Copy link
Contributor

kmpaul commented Apr 21, 2020

Why is there a permissions error in the binderbot test?

Copy link
Contributor

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the binderbot test can pass, I'll approve.

@andersy005
Copy link
Contributor Author

Why is there a permissions error in the binderbot test?

I don't know yet. I will look into it tomorrow

Copy link
Contributor

@kmpaul kmpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this fixes the problem, but try this...

.github/workflows/binderbot.yaml Outdated Show resolved Hide resolved
@kmpaul
Copy link
Contributor

kmpaul commented Apr 27, 2020

Ok. This fixed some of the problems. Some notebooks don't run for other reasons:

  1. notebooks/Run-Anywhere/mpas/plot_of_surface_pressure_on_mpas_grid.ipynb:

    NoSuchKernel: No such kernel named conda-env-notebook-gallery-py
  2. notebooks/Run-Anywhere/mpas/plot_terrain.ipynb:

    OSError: ./MPL_terrain.rgb not found.

@bonnland
Copy link
Contributor

OSError: ./MPL_terrain.rgb not found.

@kmpaul I believe this is because the kernel's working directory is not the mpas folder. Is there some way the working directory can be changed?

@andersy005
Copy link
Contributor Author

OSError: ./MPL_terrain.rgb not found.

@kmpaul I believe this is because the kernel's working directory is not the mpas folder. Is there some way the working directory can be changed?

This is a binderbot issue. I reported it in pangeo-gallery/binderbot#28

@kmpaul
Copy link
Contributor

kmpaul commented Apr 28, 2020

Is there a work-around? Or would moving this to a new repository with the proper structure be best?

@bonnland
Copy link
Contributor

Is there a work-around?

We could pooch-ify it as a workaround. It's a custom colormap with RGB values, so it seems a little silly to make people download it, but it would probably solve the issue for now.

@kmpaul
Copy link
Contributor

kmpaul commented Apr 28, 2020

What about a new repo with a different structure? Is that a better solution?

@bonnland
Copy link
Contributor

What about a new repo with a different structure?

If I understand the Github issue Anderson referenced, the problem is that only notebook files will be transferred, rather than all files in the folder, so I'm not sure how a different repo structure would fix that. It seems the author is planning on uploading all files in the next version, so that should solve the problem.

@kmpaul
Copy link
Contributor

kmpaul commented Apr 28, 2020

@bonnland Ah! I see. It doesn't look like there is a time-line for the v1 release. Maybe we can help Yuvi with it.

@andersy005 andersy005 closed this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants