Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update "unsupported registry index name" error message to provide additional useful information #234

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

alexdunnjpl
Copy link
Contributor

🗒️ Summary

Previously, error would report that value was not in the list of valid values, but not what those values are.

New message spits out the supported values enumeration.

⚙️ Test Data and/or Report

Manually tested with invalid index name in configuration - scope is small enough that that should be sufficient.

♻️ Related Issues

Fixes #233

@alexdunnjpl alexdunnjpl requested a review from a team as a code owner March 11, 2025 17:55
@alexdunnjpl
Copy link
Contributor Author

@nutjob4life @tloubrieu-jpl @jordanpadams @al-niessner any chance of a CR lads?

Copy link
Member

@nutjob4life nutjob4life left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

(Review based solely on visual inspection—trust accordingly)

@alexdunnjpl alexdunnjpl merged commit 8ee2e5f into main Mar 27, 2025
4 checks passed
@alexdunnjpl alexdunnjpl deleted the exception-improvement branch March 27, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported index name log message could be more useful
3 participants