Merge pull request #234 from NASA-PDS/exception-improvement

update "unsupported registry index name" error message to provide additional useful information

Author: alexdunnjpl

src/main/java/gov/nasa/pds/harvest/cfg/ConfigManager.java

@@ -59,8 +59,11 @@ static public List<String> exchangeLidvids (List<CollectionType> ids) {
       return lidvids;
     }
     static public String exchangeIndexForNode (String indexName) {
-      if (indexNodeMap.containsKey (indexName)) return indexNodeMap.get(indexName);
-      throw new IllegalArgumentException("Index (" + indexName + ") + not supported: either fix it in your configuration by using one of the supported or request an upgrade of harvest to support your new index by submitting a ticket on https://github.com/NASA-PDS/harvest/issues");
+      if (!indexNodeMap.containsKey (indexName)) {
+        throw new IllegalArgumentException("Index \"" + indexName + "\" is not one of the supported indices (\"" + String.join("\", \"", indexNodeMap.keySet()) + "\"): use a supported index name in your configuration or request that index \"" + indexName + "\" be added to harvest by submitting a ticket on https://github.com/NASA-PDS/harvest/issues");
+      }
+
+      return indexNodeMap.get(indexName);
     }
     static public ConnectionFactory exchangeRegistry (RegistryType xml) throws Exception {
       return EstablishConnectionFactory.from (xml.getValue(), xml.getAuth());