Skip to content

Conversation

@lavanya3k
Copy link
Collaborator

@lavanya3k lavanya3k commented Aug 4, 2025

Description of the PR: This is the code change for issue #333. The schema for the project/Shortname is updated to Campaign/Shortname. The error message for the absence of a missing campaign shortname is updated as per the ticket.

For the 3rd section - Currently, it is NOT possible to include a GCMD keyword check for 'Campaign/Shortname' for granules separately since it is tied with the specific collection (See the .native file for granule in Earthdata search). The GCMD keyword check is tied to the collection. For example, if the GCMD keyword check fails for the collection (already included in the CMR ticket), then it is likely that the GCMD keyword should fail for the granule. Need further testing on this section. Possible suggestions are to cross-validate the GCMD keyword check for the granule with collection (based on pre-existing checks).

Code change: A code change was made in the rules_override.json and check_messages_override.json. Further, we updated the outdated files in the test_downloader.py and schema_validator.py. There was an outdated imports DraftValidator, and this has to be updated before every commit. The final code is test by running pytest, and the run was successful before committing the code changes.
Note: When running pytest, I get a warning message saying the library 'datetime.datetime.utcfromtimestamp() is deprecated. This means we need to update or replace 'pytz' in the datetime_validator.py

Records for testing:
G2479735136-CDDIS (umm-g)
G1004960419-CDDIS (umm-g), Collection C1000000011-CDDIS
G1811369774-CDDIS (umm-g), C1422097980-CDDIS

Expected output:
Screenshot 2025-08-04 at 2 21 59 PM
For the collection C1000000011-CDDIS

Screenshot 2025-08-04 at 3 31 18 PM

Copy link
Member

@slesaad slesaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update in the regular jsons, not overrides

@slesaad slesaad merged commit 8f8bc7c into dev Aug 12, 2025
1 check passed
@slesaad slesaad deleted the granule-campaign-shortname-la branch August 12, 2025 14:14
@FBayat021
Copy link

@lavanya3k @slesaad: The command --concept_ids GRANULE CONCEPT ID --format umm-g is not working in the dev branch. Please address this issue before merging the fix into the master branch.

I tested this on G1811369774-CDDIS --format umm-g in dev, and it didn’t work. However, the command works in the master branch.

@lavanya3k
Copy link
Collaborator Author

Testing in the dev branch: The campaign shortname for granule works. But the Projects/Shortname does not work for the Collection. Additional, we also get the url_description_uniqueness_check error, which is another PR.

Example:
G2479735136-CDDIS (umm-g)
G1004960419-CDDIS (umm-g), Collection C1000000011-CDDIS
G1811369774-CDDIS (umm-g), C1422097980-CDDIS

Expected output:

Screenshot 2025-10-15 at 11 38 34 AM

@lavanya3k lavanya3k mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants