-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudTrail Improvements to avoid prowler alerts #342
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
e03de4c
point to fork cloudtrail s3 buckets
bcarranza c0d7db3
point to master temporarlly
bcarranza 905dea1
pointing to cloudtrail master fork temp
bcarranza 544f86c
fix point to master
bcarranza da16646
add retention 365 days as compliance
bcarranza 10dbd9c
add kms key to cloud trail
bcarranza 25a025d
cloud multiregion variable
bcarranza 0645aaf
add aws_iam_policy_document
bcarranza e895633
add policy kms
bcarranza 6c970b5
add arnformat current partition
bcarranza 3532f8a
add aws partition
bcarranza 3b64f6a
remove kms assignation
bcarranza 6880c2d
add kms master key
bcarranza f1648b6
rollback
bcarranza eca9887
remove master key
bcarranza a0a62c6
add restrict_public_buckets
bcarranza 3d566a8
testing sse algorithm
bcarranza a6c0f77
fix wrong argument
bcarranza bdd3682
pointing to new version 0.24.0
bcarranza ee20f08
separte policies
bcarranza ea3ce94
able resources
bcarranza cbf31c3
putretention policy
bcarranza d3d461a
putretentionpolicy
bcarranza 7357e76
remove put retention policy
bcarranza 7dba57c
add docs
bcarranza 2957d33
add reference to issues
bcarranza File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be enabled by default? Doesnt prowler want this as well?